Skip to content

Add pragma renderer only for planar reflection preview shader #7058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2022
Merged

Add pragma renderer only for planar reflection preview shader #7058

merged 2 commits into from
Feb 11, 2022

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Feb 9, 2022 •
edited
Loading

Purpose of this PR

Add pragma only shader to preview shader so it don't compil with opengl

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions github-actions bot added the HDRP label Feb 9, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@theopnv
Copy link
Contributor

theopnv commented Feb 9, 2022 •
edited
Loading

Thanks.
I will approve if/when these tests are green https://katana.ds.unity3d.com/projects/Unity/builders/proj0-Test%20EditorTests%20-%20Linux64Editor%20%28Isolated%20Packages%20Verified%20-%20ubuntu%201804%29?unity_branch=graphics/vendoring/2022-02-04 (I cherry picked the PR), but I can't do a technical review of the code.

@sebastienlagarde sebastienlagarde marked this pull request as ready for review February 10, 2022 10:44
@sebastienlagarde sebastienlagarde merged commit a59573a into master Feb 11, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-renderer-only branch February 11, 2022 09:18
sebastienlagarde added a commit that referenced this pull request Feb 21, 2022
@sebastienlagarde
Add pragma renderer only for planar reflection preview shader #7058
554f399
sebastienlagarde added a commit that referenced this pull request Feb 21, 2022
@sebastienlagarde
Add pragma renderer only for planar reflection preview shader (#7058)
789bf7b 
* Add pragma renderer only for planar reflection preview shader

* various missing part
sebastienlagarde added a commit that referenced this pull request Feb 22, 2022
@sebastienlagarde @Vic-Cooper
@eturquin @alelievr @JulienIgnace-Unity @emilybrown1
[HDRP] Backport various PRs (#7232)
5a219c5 
* Improve Path tracing docs #6494

* [HDRP] Improves robustness of detail normal mapping when scale = 0 (and not using surface gradients) #6980

* Add pragma renderer only for planar reflection preview shader (#7058)

* Add pragma renderer only for planar reflection preview shader

* various missing part

* Fix wrong class name in the CustomPassUtils doc (#7063)

* Fix null check reference in CollectLightsForRayTracing (Fix 1398381) #7065

* Fixed camera motion vector pass reading last frame depth texture #7111

* Update Custom-Pass-Injection-Points.md (#7116)

* Update Custom-Pass-Injection-Points.md (#7116)

* Fix lunix compil issues (#7143)

* note bolding (#7161)

* note bolding

* Apply formatting changes

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* updated screenshots (#7164)

* updated screenshots

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Mar 2, 2022
@sebastienlagarde @JulienIgnace-Unity
@adrien-de-tocqueville @johnpars @FrancescoC-unity
[HDRP] Backprot various PRs to 10.x.X/release (#7229)
eb94a91 
* Merge Hd/bugfix #6791

* Updated Physically Based Sky documentation with more warnings about warmup cost. #6498

* Rename vertex color mode option #6795

* Initial commit - update the docs (#6819)

* [Hdrp] Merge Hd/bugfix #6954

* Fix for Final Image Histogram debug mode not working on some hardware #7041

* Add pragma renderer only for planar reflection preview shader #7058

* Revert shadow caching code

* Update HDRenderPipeline.cs

* Revert wrong backport of #6952

Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: John Parsaie <johnpa@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
@sebastienlagarde sebastienlagarde mentioned this pull request Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theopnv theopnv Awaiting requested review from theopnv

Assignees
No one assigned
Labels
backported-10.x backported-2021.1 backported-2021.2 HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastienlagarde @theopnv