Skip to content

note bolding #7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 18, 2022
Merged

note bolding #7161

merged 8 commits into from
Feb 18, 2022

Conversation

emilybrown1
Copy link
Contributor

Part of a quality review of HDRP docs.

Fixed unbolded note.

@github-actions github-actions bot added the HDRP label Feb 16, 2022
@github-actions
Copy link

github-actions bot commented Feb 16, 2022 •
edited
Loading

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@emilybrown1
Copy link
Contributor Author

+ono

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@emilybrown1 emilybrown1 requested a review from a team as a code owner February 16, 2022 15:34
@sebastienlagarde sebastienlagarde changed the base branch from master to hd/doc February 18, 2022 18:04
@sebastienlagarde sebastienlagarde changed the base branch from hd/doc to master February 18, 2022 18:07
@sebastienlagarde
Copy link
Contributor

no idea what is happening with urp file

@sebastienlagarde sebastienlagarde merged commit 03679fa into master Feb 18, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/docs/quality-ambient-occlusion branch February 18, 2022 18:07
sebastienlagarde added a commit that referenced this pull request Feb 18, 2022
@emilybrown1 @sebastienlagarde
note bolding (#7161)
4978fad 
* note bolding

* Apply formatting changes

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Feb 18, 2022
@emilybrown1 @sebastienlagarde
note bolding (#7161)
54ff23a 
* note bolding

* Apply formatting changes

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Feb 21, 2022
@emilybrown1 @sebastienlagarde
note bolding (#7161)
3aed00b 
* note bolding

* Apply formatting changes

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Feb 22, 2022
@sebastienlagarde @Vic-Cooper
@eturquin @alelievr @JulienIgnace-Unity @emilybrown1
[HDRP] Backport various PRs (#7232)
5a219c5 
* Improve Path tracing docs #6494

* [HDRP] Improves robustness of detail normal mapping when scale = 0 (and not using surface gradients) #6980

* Add pragma renderer only for planar reflection preview shader (#7058)

* Add pragma renderer only for planar reflection preview shader

* various missing part

* Fix wrong class name in the CustomPassUtils doc (#7063)

* Fix null check reference in CollectLightsForRayTracing (Fix 1398381) #7065

* Fixed camera motion vector pass reading last frame depth texture #7111

* Update Custom-Pass-Injection-Points.md (#7116)

* Update Custom-Pass-Injection-Points.md (#7116)

* Fix lunix compil issues (#7143)

* note bolding (#7161)

* note bolding

* Apply formatting changes

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

* Update blit-overview.md

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* updated screenshots (#7164)

* updated screenshots

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vic-Cooper Vic-Cooper Awaiting requested review from Vic-Cooper

1 more reviewer

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backported-2021.2 backported-2022.1 HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilybrown1 @sebastienlagarde