-
Notifications
You must be signed in to change notification settings - Fork 850
Improve Path tracing docs #6494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Revised the section "How to enable path tracing on a Material", with approval from docs reviewers.
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
It appears that you made a non-draft PR! |
@sebastienlagarde Resolved merge conflict. |
com.unity.render-pipelines.high-definition/Documentation~/Ray-Tracing-Path-Tracing.md
Outdated
Show resolved
Hide resolved
as per Sebastien's suggestion.
com.unity.render-pipelines.high-definition/Documentation~/Ray-Tracing-Path-Tracing.md
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Documentation~/Ray-Tracing-Path-Tracing.md
Show resolved
Hide resolved
Added new screenshots, clarified existing content regarding path tracing and Material parameters.
- Light refraction in transmissive objects. | ||
- Light absorption in transmissive objects. | ||
- Subsurface scattering. | ||
When you use path tracing, the **Double-Sided** property (menu: **Inspector** > **Surface Options** > **Double-Sided**) allows transparent materials to accumulate correctly. If the you disable **Double-sided** property, rays can't exit the GameObject. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"If the you disable Double-sided property, rays can't exit the GameObject."
to be replaced by
"If you disable the Double-sided property, rays which exit the GameObject will not be properly considered as such."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or something like that; basically the rays will still exit, but not in the expected way, and the resulting computation will not produce the correct result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replace by " rays which exit the GameObject will not behave correctly.". I will merge the PR for the cutoff, but feel free to make a new PR with a correction for this particular sentence if it isn't satisfying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Baring a minor change on rays exiting objects, it's all good!
* Improve Path tracing docs #6494 * [HDRP] Improves robustness of detail normal mapping when scale = 0 (and not using surface gradients) #6980 * Add pragma renderer only for planar reflection preview shader (#7058) * Add pragma renderer only for planar reflection preview shader * various missing part * Fix wrong class name in the CustomPassUtils doc (#7063) * Fix null check reference in CollectLightsForRayTracing (Fix 1398381) #7065 * Fixed camera motion vector pass reading last frame depth texture #7111 * Update Custom-Pass-Injection-Points.md (#7116) * Update Custom-Pass-Injection-Points.md (#7116) * Fix lunix compil issues (#7143) * note bolding (#7161) * note bolding * Apply formatting changes * Update blit-overview.md * Update blit-overview.md * Update blit-overview.md * Update blit-overview.md * Update blit-overview.md * Update blit-overview.md Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * updated screenshots (#7164) * updated screenshots * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Revised the section "How to enable path tracing on a Material", with approval from docs reviewers.