Skip to content

removed italics and fixed menu formatting #6937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

emilybrown1
Copy link
Contributor

Part of a quality review of HDRP docs.

Removed italics and fixed menu formatting

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

4. If the image does not converge over time, select the drop-down next to the effect toggle and enable Always Refresh.
2. In the Inspector, select **Add Override** > **Ray Tracing** > **Path Tracing**.
3. In the Inspector for the Path Tracing Volume Override, check the Enable option. If you don't see the Enable option, make sure your HDRP Project supports ray tracing. For information on setting up ray tracing in HDRP, see [getting started with ray tracing](Ray-Tracing-Getting-Started.md). This switches HDRP to path-traced rendering and you should initially see a noisy image that converges towards a clean result.
4. If the image doesn't converge over time, in the Scene view toolbar, select the drop-down next to the effect toggle and enable Always Refresh.

![](Images/RayTracingPathTracing3.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This screenshot needs updating.

@@ -67,23 +67,23 @@ For that reason, some parameters have no effect in path tracing, while others be

### Refraction model
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I re-wrote this section and it should have been merged. I'll go investigate this.

Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thi page needs a lot of work but I've done most of it already :D AWe just need to figure out why it's not actually pushed... I'll approve this but be careful of merge conflicts.

@sebastienlagarde sebastienlagarde changed the base branch from master to HDRP/doc-update February 4, 2022 16:46
@sebastienlagarde
Copy link
Contributor

The other PR is this: #6494. We have a meeting with Vic to talk about it, but it will need rewording. For now I will merge this one as it ahve small adjustement.

@sebastienlagarde sebastienlagarde merged commit 1965b10 into HDRP/doc-update Feb 4, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/docs/quality-ray-tracing-path-tracing branch February 4, 2022 16:47
sebastienlagarde added a commit that referenced this pull request Feb 4, 2022
* list formatting (#6934)

* list formatting

* Update Ray-Traced-Global-Illumination.md

* removed italics and fixed list formatting (#6936)

* removed italics and fixed menu formatting (#6937)

* removed italics and fixed menu formatting

* updated screenshot

* replaced screenshot (#6941)

* Updated screenshot (#6962)

* note formatting and captions (#6973)

* note formatting and captions

* Update Post-Processing-Main.md

* Initialism (#6974)

* added anchor link (#6983)

* paragraph restructures, formatting fixes (#6998)

* fixed table subproperty (#7000)

* menu path and list formatting (#7001)

* Apply formatting changes

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Feb 4, 2022
* list formatting (#6934)

* list formatting

* Update Ray-Traced-Global-Illumination.md

* removed italics and fixed list formatting (#6936)

* removed italics and fixed menu formatting (#6937)

* removed italics and fixed menu formatting

* updated screenshot

* replaced screenshot (#6941)

* Updated screenshot (#6962)

* note formatting and captions (#6973)

* note formatting and captions

* Update Post-Processing-Main.md

* Initialism (#6974)

* added anchor link (#6983)

* paragraph restructures, formatting fixes (#6998)

* fixed table subproperty (#7000)

* menu path and list formatting (#7001)

* Apply formatting changes

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants