Skip to content

note formatting and captions #6973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2022
Merged

note formatting and captions #6973

merged 2 commits into from
Feb 4, 2022

Conversation

emilybrown1
Copy link
Contributor

Part of a quality review of HDRP docs.

Fixed note formatting and moved image captions.

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Feb 3, 2022
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Vic-Cooper
Vic-Cooper requested changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small notes.

Vic-Cooper
Vic-Cooper requested changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed :) header link etc...

@sebastienlagarde sebastienlagarde changed the base branch from master to HDRP/doc-update February 4, 2022 16:51
@sebastienlagarde sebastienlagarde merged commit ab2d323 into HDRP/doc-update Feb 4, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/docs/quality-post-processing-main branch February 4, 2022 16:51
sebastienlagarde added a commit that referenced this pull request Feb 4, 2022
@sebastienlagarde @emilybrown1
[HDRP] Various Docs PRs (#7007)
01ac67b 
* list formatting (#6934)

* list formatting

* Update Ray-Traced-Global-Illumination.md

* removed italics and fixed list formatting (#6936)

* removed italics and fixed menu formatting (#6937)

* removed italics and fixed menu formatting

* updated screenshot

* replaced screenshot (#6941)

* Updated screenshot (#6962)

* note formatting and captions (#6973)

* note formatting and captions

* Update Post-Processing-Main.md

* Initialism (#6974)

* added anchor link (#6983)

* paragraph restructures, formatting fixes (#6998)

* fixed table subproperty (#7000)

* menu path and list formatting (#7001)

* Apply formatting changes

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Feb 4, 2022
@sebastienlagarde @emilybrown1
[HDRP] Various Docs PRs (#7007)
0a8e227 
* list formatting (#6934)

* list formatting

* Update Ray-Traced-Global-Illumination.md

* removed italics and fixed list formatting (#6936)

* removed italics and fixed menu formatting (#6937)

* removed italics and fixed menu formatting

* updated screenshot

* replaced screenshot (#6941)

* Updated screenshot (#6962)

* note formatting and captions (#6973)

* note formatting and captions

* Update Post-Processing-Main.md

* Initialism (#6974)

* added anchor link (#6983)

* paragraph restructures, formatting fixes (#6998)

* fixed table subproperty (#7000)

* menu path and list formatting (#7001)

* Apply formatting changes

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vic-Cooper Vic-Cooper Awaiting requested review from Vic-Cooper

1 more reviewer

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilybrown1 @sebastienlagarde @Vic-Cooper