Fix null check reference in CollectLightsForRayTracing (Fix 1398381) #7065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
sebastienlagarde
changed the title
patrickp-unity3d
approved these changes
Feb 9, 2022
sebastienlagarde
added
backported-2021.1
backported-2021.2
and removed
needs-backport-2021.2
needs-backport-2022.1
labels
sebastienlagarde
added a commit
that referenced
this pull request
Feb 21, 2022
sebastienlagarde
added a commit
that referenced
this pull request
Feb 22, 2022
* Improve Path tracing docs #6494 * [HDRP] Improves robustness of detail normal mapping when scale = 0 (and not using surface gradients) #6980 * Add pragma renderer only for planar reflection preview shader (#7058) * Add pragma renderer only for planar reflection preview shader * various missing part * Fix wrong class name in the CustomPassUtils doc (#7063) * Fix null check reference in CollectLightsForRayTracing (Fix 1398381) #7065 * Fixed camera motion vector pass reading last frame depth texture #7111 * Update Custom-Pass-Injection-Points.md (#7116) * Update Custom-Pass-Injection-Points.md (#7116) * Fix lunix compil issues (#7143) * note bolding (#7161) * note bolding * Apply formatting changes * Update blit-overview.md * Update blit-overview.md * Update blit-overview.md * Update blit-overview.md * Update blit-overview.md * Update blit-overview.md Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * updated screenshots (#7164) * updated screenshots * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
Attempt to fix https://fogbugz.unity3d.com/f/cases/1398381/ with a blind addition of null check reference. We can't reproduce the issue but adding those check don't harm and can prevent future error
Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.