Skip to content

Fix for Final Image Histogram debug mode not working on some hardware #7041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 8, 2022
Merged

Fix for Final Image Histogram debug mode not working on some hardware #7041

merged 3 commits into from
Feb 8, 2022

Conversation

FrancescoC-unity
Copy link
Contributor

Fix for the issue in the smoke test doc and https://fogbugz.unity3d.com/f/cases/1400111/

I can't repro myself, but verified the fix with @TomasKiniulis that could repro before, but not now.

The issue was due to the fact that the stride of the buffer was wrong, I assume on some hardware the buffer is unrolled into uint-separated data anyhow so it ends up working.

Anyhow, this is correct and now all works apparently :P

@FrancescoC-unity FrancescoC-unity self-assigned this Feb 8, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Feb 8, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

TomasKiniulis
TomasKiniulis approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@TomasKiniulis TomasKiniulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tried checking multiple scene views and game view. Retoggling debug mode. Values are displayed correctly with Display RGB Histogram on/off and changing exposure compensation.

2022-02-08.15-41-13.mp4

@sebastienlagarde sebastienlagarde merged commit f60c2dc into master Feb 8, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-final-image-histogram-on-some-platforms branch February 8, 2022 14:54
sebastienlagarde pushed a commit that referenced this pull request Feb 8, 2022
@FrancescoC-unity @sebastienlagarde
Fix for Final Image Histogram debug mode not working on some hardware #…
5ccdfc3 
…7041
@sebastienlagarde sebastienlagarde mentioned this pull request Feb 8, 2022
Merged
sebastienlagarde added a commit that referenced this pull request Feb 8, 2022
@sebastienlagarde @emilybrown1
@ValGrimm-U3D @TomasKiniulis @JulienIgnace-Unity @FrancescoC-unity @kecho @alelievr
[HDRP] Backport various PRs (#7054)
48c44f4 
* Update Light Anchor page (#6955)

* Updated Light Anchor to match Core RP page

* added light anchor page to ToC

* Update light-anchor.md

* Update Environment Lighting doc (#7008)

The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.

* Disable main camera in compositor scene (#7038)

* Fixed various issues with render graph viewer when entering playmode. #7040

* Fix for Final Image Histogram debug mode not working on some hardware #7041

* Fixed HDRP camera debug panel rendering foldout. (#7043)

* ** Whats new light loop information ** (#7047)

* Grammar

* Formatting

* Correct version

* [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052)

* update what's new and upgrade guide

* move upgrade guide

* Update Upgrading-from-2021.1-to-2021.2.md

* Update Upgrading-from-2022.1-to-2022.2.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* removed duplicated sentence (#6999)

* removed italics, fixed notes (#7021)

* removed italics, fixed notes

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

* recommended import settings (#7023)

* api formatting (#7027)

* Updated Light Anchor page in line with updated HDRP page (#6956)

* Updated Light Anchor page in line with updated HDRP page

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: Val Grimm <72067840+ValGrimm-U3D@users.noreply.github.com>
Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Feb 8, 2022
@sebastienlagarde @emilybrown1
@ValGrimm-U3D @TomasKiniulis @JulienIgnace-Unity @FrancescoC-unity @kecho @alelievr
[HDRP] Backport various PRs (#7054)
01c3a39 
* Update Light Anchor page (#6955)

* Updated Light Anchor to match Core RP page

* added light anchor page to ToC

* Update light-anchor.md

* Update Environment Lighting doc (#7008)

The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.

* Disable main camera in compositor scene (#7038)

* Fixed various issues with render graph viewer when entering playmode. #7040

* Fix for Final Image Histogram debug mode not working on some hardware #7041

* Fixed HDRP camera debug panel rendering foldout. (#7043)

* ** Whats new light loop information ** (#7047)

* Grammar

* Formatting

* Correct version

* [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052)

* update what's new and upgrade guide

* move upgrade guide

* Update Upgrading-from-2021.1-to-2021.2.md

* Update Upgrading-from-2022.1-to-2022.2.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* removed duplicated sentence (#6999)

* removed italics, fixed notes (#7021)

* removed italics, fixed notes

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

* recommended import settings (#7023)

* api formatting (#7027)

* Updated Light Anchor page in line with updated HDRP page (#6956)

* Updated Light Anchor page in line with updated HDRP page

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: Val Grimm <72067840+ValGrimm-U3D@users.noreply.github.com>
Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
sebastienlagarde pushed a commit that referenced this pull request Feb 21, 2022
@FrancescoC-unity @sebastienlagarde
Fix for Final Image Histogram debug mode not working on some hardware #…
1c6fb31 
…7041
sebastienlagarde added a commit that referenced this pull request Mar 2, 2022
@sebastienlagarde @JulienIgnace-Unity
@adrien-de-tocqueville @johnpars @FrancescoC-unity
[HDRP] Backprot various PRs to 10.x.X/release (#7229)
eb94a91 
* Merge Hd/bugfix #6791

* Updated Physically Based Sky documentation with more warnings about warmup cost. #6498

* Rename vertex color mode option #6795

* Initial commit - update the docs (#6819)

* [Hdrp] Merge Hd/bugfix #6954

* Fix for Final Image Histogram debug mode not working on some hardware #7041

* Add pragma renderer only for planar reflection preview shader #7058

* Revert shadow caching code

* Update HDRenderPipeline.cs

* Revert wrong backport of #6952

Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: John Parsaie <johnpa@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
@sebastienlagarde sebastienlagarde mentioned this pull request Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@TomasKiniulis TomasKiniulis TomasKiniulis approved these changes

Assignees

@FrancescoC-unity FrancescoC-unity

Labels
backported-10.x backported-2021.2 backported-2022.1 HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrancescoC-unity @sebastienlagarde @TomasKiniulis