Fixed HDRP camera debug panel rendering foldout. #7043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienIgnace-Unity
requested review from
sebastienlagarde,
RemyUnity and
alex-vazquez
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
alex-vazquez
approved these changes
Feb 8, 2022
TomasKiniulis
approved these changes
Feb 8, 2022
sebastienlagarde
approved these changes
Feb 8, 2022
sebastienlagarde
added
backported-2021.2
backported-2022.1
and removed
needs-backport-2021.2
needs-backport-2022.1
labels
sebastienlagarde
pushed a commit
that referenced
this pull request
Feb 8, 2022
sebastienlagarde
added a commit
that referenced
this pull request
Feb 8, 2022
* Update Light Anchor page (#6955) * Updated Light Anchor to match Core RP page * added light anchor page to ToC * Update light-anchor.md * Update Environment Lighting doc (#7008) The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu. * Disable main camera in compositor scene (#7038) * Fixed various issues with render graph viewer when entering playmode. #7040 * Fix for Final Image Histogram debug mode not working on some hardware #7041 * Fixed HDRP camera debug panel rendering foldout. (#7043) * ** Whats new light loop information ** (#7047) * Grammar * Formatting * Correct version * [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052) * update what's new and upgrade guide * move upgrade guide * Update Upgrading-from-2021.1-to-2021.2.md * Update Upgrading-from-2022.1-to-2022.2.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * removed duplicated sentence (#6999) * removed italics, fixed notes (#7021) * removed italics, fixed notes * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> * recommended import settings (#7023) * api formatting (#7027) * Updated Light Anchor page in line with updated HDRP page (#6956) * Updated Light Anchor page in line with updated HDRP page * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: Val Grimm <72067840+ValGrimm-U3D@users.noreply.github.com> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Feb 8, 2022
* Update Light Anchor page (#6955) * Updated Light Anchor to match Core RP page * added light anchor page to ToC * Update light-anchor.md * Update Environment Lighting doc (#7008) The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu. * Disable main camera in compositor scene (#7038) * Fixed various issues with render graph viewer when entering playmode. #7040 * Fix for Final Image Histogram debug mode not working on some hardware #7041 * Fixed HDRP camera debug panel rendering foldout. (#7043) * ** Whats new light loop information ** (#7047) * Grammar * Formatting * Correct version * [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052) * update what's new and upgrade guide * move upgrade guide * Update Upgrading-from-2021.1-to-2021.2.md * Update Upgrading-from-2022.1-to-2022.2.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * removed duplicated sentence (#6999) * removed italics, fixed notes (#7021) * removed italics, fixed notes * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> * recommended import settings (#7023) * api formatting (#7027) * Updated Light Anchor page in line with updated HDRP page (#6956) * Updated Light Anchor page in line with updated HDRP page * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: Val Grimm <72067840+ValGrimm-U3D@users.noreply.github.com> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
fogbugz
Fixed HDRP camera debug panel rendering foldout not showing any item.
Testing status
Tested the repro from the package verification doc.
Comments to reviewers
Notes for the reviewers you have assigned.