Updated Light Anchor page in line with updated HDRP page #6956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
Vic-Cooper
approved these changes
Feb 3, 2022
com.unity.render-pipelines.core/Documentation~/View-Lighting-Tool.md
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.core/Documentation~/View-Lighting-Tool.md
Outdated
Show resolved
Hide resolved
|
|
||
| Use the **Orbit** and **Elevation** to control the orientation of the light, in degrees, relative to the main Camera's and Anchor's positions. If the Light has a Cookie or an IES Profile, use the **Roll** to change their orientation. Use the **Distance** to control how far from the anchor, in meters, you want to place the Light. | ||
|
|
||
| Using the **Anchor Position Override**, you can provide a custom GameObject as an anchor point for the light. This is useful if you want the light to follow a specific GameObject in the Scene. | ||
| Using the **Anchor Position Override**, you can provide a GameObject’s [Transform](https://docs.unity3d.com/ScriptReference/Transform.html) as an anchor point for the light. This is useful if you want the light to follow a specific GameObject in the Scene. |
There was a problem hiding this comment.
Avoid gerunds like "using". Instead, rely on the present tense to be direct:
"You can use the Anchor Position Override to provide a GameObject’s [Transform]..."
Also should "light" always be capitalised? this instance isn't
|
|
||
|  | ||
|
|
||
| **Note**: The reference Camera that adjusts the light rotation in the above example is the Main Camera. This means that the Common presets can create a different result in the Scene View if your view isn't aligned with the Main Camera. |
There was a problem hiding this comment.
I think this note could be more clear. It's not clear what "different" means here. You'll get different results from the screenshot above? Also "can"? Is this always the case or is it contitional? In short, do the Common presets use the Main Camera as the camera that adjusts the light rotation? If not, it's more important to state that and make sure the user knows how to assign it.
com.unity.render-pipelines.core/Documentation~/View-Lighting-Tool.md
Outdated
Show resolved
Hide resolved
sebastienlagarde
approved these changes
Feb 8, 2022
sebastienlagarde
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Updated Light Anchor page in line with updated HDRP page * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Feb 8, 2022
* Update Light Anchor page (#6955) * Updated Light Anchor to match Core RP page * added light anchor page to ToC * Update light-anchor.md * Update Environment Lighting doc (#7008) The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu. * Disable main camera in compositor scene (#7038) * Fixed various issues with render graph viewer when entering playmode. #7040 * Fix for Final Image Histogram debug mode not working on some hardware #7041 * Fixed HDRP camera debug panel rendering foldout. (#7043) * ** Whats new light loop information ** (#7047) * Grammar * Formatting * Correct version * [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052) * update what's new and upgrade guide * move upgrade guide * Update Upgrading-from-2021.1-to-2021.2.md * Update Upgrading-from-2022.1-to-2022.2.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * removed duplicated sentence (#6999) * removed italics, fixed notes (#7021) * removed italics, fixed notes * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> * recommended import settings (#7023) * api formatting (#7027) * Updated Light Anchor page in line with updated HDRP page (#6956) * Updated Light Anchor page in line with updated HDRP page * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: Val Grimm <72067840+ValGrimm-U3D@users.noreply.github.com> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Feb 8, 2022
* Update Light Anchor page (#6955) * Updated Light Anchor to match Core RP page * added light anchor page to ToC * Update light-anchor.md * Update Environment Lighting doc (#7008) The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu. * Disable main camera in compositor scene (#7038) * Fixed various issues with render graph viewer when entering playmode. #7040 * Fix for Final Image Histogram debug mode not working on some hardware #7041 * Fixed HDRP camera debug panel rendering foldout. (#7043) * ** Whats new light loop information ** (#7047) * Grammar * Formatting * Correct version * [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052) * update what's new and upgrade guide * move upgrade guide * Update Upgrading-from-2021.1-to-2021.2.md * Update Upgrading-from-2022.1-to-2022.2.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * removed duplicated sentence (#6999) * removed italics, fixed notes (#7021) * removed italics, fixed notes * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> * recommended import settings (#7023) * api formatting (#7027) * Updated Light Anchor page in line with updated HDRP page (#6956) * Updated Light Anchor page in line with updated HDRP page * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Update View-Lighting-Tool.md * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: Val Grimm <72067840+ValGrimm-U3D@users.noreply.github.com> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matched SRP Light Anchor page to updated HDRP page. Added gif.
In response to https://jira.unity3d.com/browse/DOCG-315