Merge Hd/bugfix #6791

sebastienlagarde · 2022-01-24T09:22:36Z

Purpose of this PR

Fixed Normal Map assiignation when importing FBX Materials (Fix fbx material #6491)
Fix sky jittering (Fix sky jittering #6678)
Make sky shadow multi compile global instead of local (Make sky shadow multi compile global instead of local #6838)
Change default custom pass format to R8G8B8A8_UNorm (Change default custom pass format to R8G8B8A8_UNorm #6854)
Fix simple lit pass not using the correct pass name for depth (Fix simple lit pass not using the correct pass name for depth #6810)
Updated screenshot (Updated screenshot #6881)
note formatting and typo (note formatting and typo #6880)
Fix cached directional shadows disappearing when going out of shadow range to never reappear (Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802)
Fixed an issue where sometimes full screen debug would cause render graph errors. (Fixed an issue where sometimes full screen debug would cause render graph errors. #6803)
Fixed a nullref exception when creating a new scene while LightExplorer is open. (Fixed a nullref exception when creating a new scene while LightExplorer is open. #6805)
Stop Uber from running if no effect that needs it is enabled (Stop Uber from running if no effect that needs it is enabled #6804)
Register shadows OnDemand to the cached shadow system only when rendered for the first time. (Register shadows OnDemand to the cached shadow system only when rendered for the first time. #6825)
Fix for issue with SSAO (and in fact anything sampling depth pyramid) at edges (Fix for issue with SSAO (and in fact anything sampling depth pyramid) at edges #6839)
[HDRP] Update custom pass doc (decals not supported by DrawRenderers custom pass) ([HDRP] Update custom pass doc (decals not supported by DrawRenderers custom pass) #6858)

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

* Fix AxF debug output in certain configurations. * Update comment

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…4599)" This reverts commit 2325e3f.

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…positor (#4599)"" This reverts commit 30fffd5.

… the Graphi

…ing only the RTSSS Data (case 1332904). (#4626) * Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). * Add test scene Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Updated screenshot * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…range to never reappear (#6802) * fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…raph errors. (#6803) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…er is open. (#6805) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…red for the first time. (#6825) * Fix a couple of issues * Changelog * Change how the registering to the sysem works for ondemand * Changelog * Fix wrong warning Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

… at edges (#6839) * tentative fix * changelog * right parenthesis Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…custom pass) (#6858) * update custom pass doc * Update Custom-Pass-Creating.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* fixed typo and made style guide fixes (#6749) * style guide fixes (#6750) * Added menu trail to change atlas resolution (#6755) * Clarified how to find hdrp in package manager (#6756) * made style guide fixes (#6762) * added new instructions for photoshop colour channels (#6769) * made naming of AO consistent (#6771) * Removed reference to 3d with extras project (#6781) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added default value (#6770) * Added default value * Fixed merge issue * undo wrong fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Merge Hd/bugfix #6791 * Fix warning on baking set renaming #6808 * Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801 * Refresh baking set scene list when one baking set is removed. #6811 * clarified how to change mode (#6871) * fixed screenshot annotation colour (#6872) * fixed formatting (#6873) * fixed name of Game view (#6874) * fixed note formatting (#6875) * new screenshot and fixed table formatting (#6889) * minor style guide changes (#6904) * remove italics, note formatting (#6906) * fixed typo "on following GPUs" > on the following GPUs (#6909) * Post Process can now be edited in the default frame settings. #6816 * Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820 * Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822 * [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826 * Fixed an issue where forced sky update would not update ambient probe. #6831 * Fixed a null ref exception in Volume Explorer #6834 * Cleaning up FPTL early out for ps4 and PC (#6882) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix static sky lighting update when render textures are updated #6863 * Quality update of custom post process (#6856) * Disable the clouds in the indoor sample scenes (normal and DXR) #6908 * Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903 * Update VolumeParameter.cs * Replaced view lighting tool with light anchor (#6829) * Replaced view lighting tool with light anchor * Update View-Lighting-Tool.md * Apply formatting changes * revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802 * [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632 * More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254 * [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901) * Proper Indoors scene template volume * Update 004-CloudsFlaresDecals.png Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>

* [HDRP 21.2] Backport various PRs (#6926) * fixed typo and made style guide fixes (#6749) * style guide fixes (#6750) * Added menu trail to change atlas resolution (#6755) * Clarified how to find hdrp in package manager (#6756) * made style guide fixes (#6762) * added new instructions for photoshop colour channels (#6769) * made naming of AO consistent (#6771) * Removed reference to 3d with extras project (#6781) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added default value (#6770) * Added default value * Fixed merge issue * undo wrong fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Merge Hd/bugfix #6791 * Fix warning on baking set renaming #6808 * Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801 * Refresh baking set scene list when one baking set is removed. #6811 * clarified how to change mode (#6871) * fixed screenshot annotation colour (#6872) * fixed formatting (#6873) * fixed name of Game view (#6874) * fixed note formatting (#6875) * new screenshot and fixed table formatting (#6889) * minor style guide changes (#6904) * remove italics, note formatting (#6906) * fixed typo "on following GPUs" > on the following GPUs (#6909) * Post Process can now be edited in the default frame settings. #6816 * Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820 * Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822 * [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826 * Fixed an issue where forced sky update would not update ambient probe. #6831 * Fixed a null ref exception in Volume Explorer #6834 * Cleaning up FPTL early out for ps4 and PC (#6882) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix static sky lighting update when render textures are updated #6863 * Quality update of custom post process (#6856) * Disable the clouds in the indoor sample scenes (normal and DXR) #6908 * Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903 * Update VolumeParameter.cs * Replaced view lighting tool with light anchor (#6829) * Replaced view lighting tool with light anchor * Update View-Lighting-Tool.md * Apply formatting changes * revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802 * [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632 * More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254 * [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901) * Proper Indoors scene template volume * Update 004-CloudsFlaresDecals.png Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com> * Fixed missing capital and UI bolding (#6876) * [RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799 * Disabled the "Reflect Sky" feature in the case of transparent screenspace reflections for the water system. #6725 Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>

* Merge Hd/bugfix #6791 * Updated Physically Based Sky documentation with more warnings about warmup cost. #6498 * Rename vertex color mode option #6795 * Initial commit - update the docs (#6819) * [Hdrp] Merge Hd/bugfix #6954 * Fix for Final Image Histogram debug mode not working on some hardware #7041 * Add pragma renderer only for planar reflection preview shader #7058 * Revert shadow caching code * Update HDRenderPipeline.cs * Revert wrong backport of #6952 Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>

pmavridis and others added 30 commits May 26, 2021 19:23

[HDRP] Fix AxF debug output in certain configurations (#4641)

5945333

* Fix AxF debug output in certain configurations. * Update comment

Fix SSR accumulation white flash (#4648)

64a6c13

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Display Info Box when MSAA + ray tracing is onr (#4627)

f49b710

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix distortion when resizing the window in player builds with the Gra…

05cc16a

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Add support for the camera bridge in the graphics compositor (#4599)

2325e3f

Merge branch 'master' into hd/bugfix

c09379f

Fix Jittered Project Matrix Infinite Far Clip Plane (#4638)

b5962c9

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed a memory leak related to not disposing of the RTAS at the end H…

77b6b7f

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix custom pass utils Blur + Copy overdraw. (#4623)

bf941a9

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix draw procedural invalid pass idx 1 on first template load (#4632)

806dfbe

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Changed light reset to preserve type (#4624)

88779ea

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Add support for the camera bridge in the graphics compositor (#…

30fffd5

…4599)" This reverts commit 2325e3f.

AxF carpaint: Fix a compilation issue on Vulkan until the cpp HLSLcc …

aabbb4b

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Revert "Add support for the camera bridge in the graphics com…

dfdb311

…positor (#4599)"" This reverts commit 30fffd5.

revert: Fix distortion when resizing the window in player builds with…

891fda0

… the Graphi

Merge branch 'master' into hd/bugfix

7b17e06

Merge branch 'master' into hd/bugfix

32df1bf

Fix for discrepancies in saturation and intensity between screen spac…

0032b9c

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

Fix a Divide-by-Zero Warning for some Anisotropic Models (Fabric, Lit) (

41716f0

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP] Fix VfX lit particle AOV output color space (#4646)

333c800

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP][Path Tracing] Fixed transparent unlit (#4605)

809316c

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

7b1ad29

Fix distortion with MSAA (#4711)

08a578d

Fix contact shadow debug views (#4720)

3c418c0

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Update Decal-Projector.md (#4695)

352f65d

[HDRP] Fixed nullref when deleting the texture asset assigned in a lo…

acc5073

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

fd54a00

Fix decal layer enum (#4753)

1672dc6

Fix typo

c40c5c5

sebastienlagarde and others added 13 commits January 28, 2022 10:00

Update CHANGELOG.md

17c0144

Updated screenshot (#6881)

e74a9df

* Updated screenshot * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

note formatting and typo (#6880)

492136f

Fix cached directional shadows disappearing when going out of shadow …

e6fac87

…range to never reappear (#6802) * fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed an issue where sometimes full screen debug would cause render g…

71e5e34

…raph errors. (#6803) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed a nullref exception when creating a new scene while LightExplor…

e88a500

…er is open. (#6805) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Stop Uber from running if no effect that needs it is enabled (#6804)

cf6499f

* Fix * changelog * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

comments and old PR revert. (#6827)

a350549

Fix for issue with SSAO (and in fact anything sampling depth pyramid)…

e9b32fe

… at edges (#6839) * tentative fix * changelog * right parenthesis Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP] Update custom pass doc (decals not supported by DrawRenderers …

71dda2a

…custom pass) (#6858) * update custom pass doc * Update Custom-Pass-Creating.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

2fec01d

Merge branch 'master' into hd/bugfix

9dc2f0e

sebastienlagarde marked this pull request as ready for review January 31, 2022 21:12

sebastienlagarde merged commit c2910b0 into master Jan 31, 2022

sebastienlagarde added backported-2021.2 and removed needs-backport-2021.2 labels Feb 1, 2022

sebastienlagarde added a commit that referenced this pull request Feb 1, 2022

Merge Hd/bugfix #6791

e0f450b

sebastienlagarde mentioned this pull request Feb 1, 2022

[HDRP 21.2] Backport various PRs #6926

Merged

sebastienlagarde added backported-2022.1 and removed needs-backport-2022.1 labels Feb 1, 2022

PaulDemeulenaere mentioned this pull request Feb 3, 2022

[VFX/HDRP] Update HDRP Debug Normal (OSX) #6972

Merged

sebastienlagarde removed the needs-backport-10.x label Feb 21, 2022

sebastienlagarde added a commit that referenced this pull request Feb 21, 2022

Merge Hd/bugfix #6791

0c53a4c

sebastienlagarde added the backported-10.x label Feb 21, 2022

sebastienlagarde mentioned this pull request Mar 2, 2022

[HDRP] Backprot various PRs to 10.x.X/release #7229

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge Hd/bugfix #6791

Merge Hd/bugfix #6791

Uh oh!

sebastienlagarde commented Jan 24, 2022 •

edited

Loading

Uh oh!

Uh oh!

Merge Hd/bugfix #6791

Merge Hd/bugfix #6791

Uh oh!

Conversation

sebastienlagarde commented Jan 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Comments to reviewers

Uh oh!

Uh oh!

sebastienlagarde commented Jan 24, 2022 •

edited

Loading