Skip to content

Update Environment Lighting doc #7008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

ValGrimm-U3D
Copy link
Contributor

The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • [ tbd as I am not sure if any backports are needed, so not yet] Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • [ n/a] Have you updated the changelog? Each package has a CHANGELOG.md file.
  • [ n/a] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • [ n/a] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?
Updating the Environment Lighting page.


Testing status

Describe what manual/automated tests were performed for this PR
n/a


Comments to reviewers

Notes for the reviewers you have assigned.
I do not know which versions I will need to backport this to, if any, because I am not sure when Static Lighting Volumetric Clouds was introduced.

The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link
Contributor

@anisunity anisunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ValGrimm-U3D ValGrimm-U3D merged commit bf2a628 into master Feb 8, 2022
@ValGrimm-U3D ValGrimm-U3D deleted the origin/hdrp/docs/explicitsunlight branch February 8, 2022 12:21
sebastienlagarde pushed a commit that referenced this pull request Feb 8, 2022
The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.
sebastienlagarde added a commit that referenced this pull request Feb 8, 2022
* Update Light Anchor page (#6955)

* Updated Light Anchor to match Core RP page

* added light anchor page to ToC

* Update light-anchor.md

* Update Environment Lighting doc (#7008)

The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.

* Disable main camera in compositor scene (#7038)

* Fixed various issues with render graph viewer when entering playmode. #7040

* Fix for Final Image Histogram debug mode not working on some hardware #7041

* Fixed HDRP camera debug panel rendering foldout. (#7043)

* ** Whats new light loop information ** (#7047)

* Grammar

* Formatting

* Correct version

* [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052)

* update what's new and upgrade guide

* move upgrade guide

* Update Upgrading-from-2021.1-to-2021.2.md

* Update Upgrading-from-2022.1-to-2022.2.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* removed duplicated sentence (#6999)

* removed italics, fixed notes (#7021)

* removed italics, fixed notes

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

* recommended import settings (#7023)

* api formatting (#7027)

* Updated Light Anchor page in line with updated HDRP page (#6956)

* Updated Light Anchor page in line with updated HDRP page

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: Val Grimm <72067840+ValGrimm-U3D@users.noreply.github.com>
Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Feb 8, 2022
* Update Light Anchor page (#6955)

* Updated Light Anchor to match Core RP page

* added light anchor page to ToC

* Update light-anchor.md

* Update Environment Lighting doc (#7008)

The Static Lighting Volumetric Clouds option is missing from the Environment Lighting page. In this PR, I add information about that option. I also added  a note about the impact of the dominant directional light on the scene based on a tooltip Julien Ignace added to the UI in #6059. Based on official docs guidance regarding maintainability (https://unity-docs.gitbook.io/style-guide/format/images/screenshots), I have also removed the screenshot of the menu.

* Disable main camera in compositor scene (#7038)

* Fixed various issues with render graph viewer when entering playmode. #7040

* Fix for Final Image Histogram debug mode not working on some hardware #7041

* Fixed HDRP camera debug panel rendering foldout. (#7043)

* ** Whats new light loop information ** (#7047)

* Grammar

* Formatting

* Correct version

* [HDRP] Update what's new and upgrade guide about decals and custom passes (#7052)

* update what's new and upgrade guide

* move upgrade guide

* Update Upgrading-from-2021.1-to-2021.2.md

* Update Upgrading-from-2022.1-to-2022.2.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* removed duplicated sentence (#6999)

* removed italics, fixed notes (#7021)

* removed italics, fixed notes

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

* recommended import settings (#7023)

* api formatting (#7027)

* Updated Light Anchor page in line with updated HDRP page (#6956)

* Updated Light Anchor page in line with updated HDRP page

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Update View-Lighting-Tool.md

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: Val Grimm <72067840+ValGrimm-U3D@users.noreply.github.com>
Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants