Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show LaTeX images inline #14727

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Show LaTeX images inline #14727

merged 3 commits into from
Feb 21, 2020

Conversation

dstein64
Copy link
Contributor

Fixes #14726

Changes proposed in this Pull Request:

  • Adds display: inline; to LaTeX images.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • This is not a new feature.

Testing instructions:

  • Change the theme to Twenty Twenty (the default theme)
  • Create a new post with the following paragraph:
    • This $latex \LaTeX$ snippet should appear inline.

The rendered LaTeX image should render inline with the surrounding text.

Proposed changelog entry for your changes:

  • Show LaTeX images inline.

Some themes have CSS rules that set display:block for images.
To match existing formatting.
@dstein64 dstein64 requested a review from a team as a code owner February 19, 2020 06:16
@jetpackbot
Copy link

jetpackbot commented Feb 19, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against 88bd135

@jeherve jeherve added [Feature] Beautiful Math [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Bug When a feature is broken and / or not performing as intended labels Feb 19, 2020
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the problem is limited to Twenty Twenty, I would be tempted to only add this to Twenty Twenty. What do you think about adding something like this to https://github.com/Automattic/jetpack/blob/d6545508fc4a48582ad443c6173cd1f25bbaddda/modules/theme-tools/compat/twentytwenty.css
:

/* Beautiful Math */
.entry-content img.latex {
        display: inline;
}

@dstein64
Copy link
Contributor Author

@jeherve, that sounds good to me. Updated in 88bd135.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 19, 2020
@jeherve jeherve added this to the 8.3 milestone Feb 19, 2020
@jeherve jeherve merged commit a49646f into Automattic:master Feb 21, 2020
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 21, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Beautiful Math Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LaTeX images don't render inline
4 participants