Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify distinction between Dashboard widgets #14574

Merged

Conversation

coleshaw
Copy link
Contributor

@coleshaw coleshaw commented Feb 5, 2020

Fixes #13952

Changes proposed in this Pull Request:

  • No functional changes, just visual changes to clarify role of each column in the Dashboard footer widget.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • If you're an Automattician, include a shortlink to the p2 discussion with Jetpack Product here.

N/A

Testing instructions:

  • Go to the admin Dashboard
  • View the Jetpack footer widget
  • See headings for "Jetpack Protect" and "Akismet" (see screenshots for examples).

Screen Shot 2020-02-10 at 7 55 37 PM

Screen Shot 2020-02-10 at 7 56 09 PM

Proposed changelog entry for your changes:

  • Add headings in Dashboard footer widget. Update copy for consistent verbiage.

Fix Automattic#13952.

Add headers to clarify that two different features
are being shown in the Dashboard footer widget,
for Jetpack.
@coleshaw coleshaw requested a review from a team as a code owner February 5, 2020 01:36
@jetpackbot
Copy link

jetpackbot commented Feb 5, 2020

Warnings
⚠️

pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against b61df6e

@jeherve jeherve added General [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Protect Also known as Brute Force Attack Protection [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. labels Feb 5, 2020
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I left some comments below.

class.jetpack.php Outdated Show resolved Hide resolved
class.jetpack.php Outdated Show resolved Hide resolved
class.jetpack.php Outdated Show resolved Hide resolved
[not verified] (giving error about not escaping the
blocked attempts / spam count)
Because Travis CI #43386.6 job timed out (??):

develop.git.wordpress.org[0: 198.143.164.245]: errno=Connection timed out

[not verified]
@coleshaw
Copy link
Contributor Author

coleshaw commented Feb 5, 2020

For reference, here is what the updated widget should look like.

Screen Shot 2020-02-05 at 1 05 59 PM

@coleshaw coleshaw requested a review from jeherve February 5, 2020 18:43
@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 10, 2020
@jeherve jeherve added this to the 8.3 milestone Feb 10, 2020
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @coleshaw !

Does that last screenshot reflect the latest changes? If so, could we replace the first one on the original post, please?

This is looking good to me, but I'd like to see two changes before merging:

  • Smaller font-size on the product name headings.
  • Slightly larger margin-bottom on those same headings.

This should make the product names complementary to the valuable information below: the actual stats and descriptions. I've added a mock on #13952 (comment) :

image

Finally, should we be using the “Anti-spam” name instead of Akismet @jeherve ?

@jeherve
Copy link
Member

jeherve commented Feb 10, 2020

should we be using the “Anti-spam” name instead of Akismet

That's a good point, let's do that!

We can take that opportunity to change "Protect" into "Brute force attack protection" as well, to stay consistent with the Jetpack Settings screen.

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Design Review Design has been added. Needs a review! [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 10, 2020
@coleshaw
Copy link
Contributor Author

@keoshi @jeherve , thanks for the feedback. I've updated the code and posted new screenshots in the original PR description. I also updated a couple instances of "Protect" and "Akismet" in the widget, not just in the heading -- do those other changes make sense? Or do you only want the headings to use "Brute force attack protection" and "Anti-spam", and I should leave the other text strings alone?

@jeherve
Copy link
Member

jeherve commented Feb 11, 2020

do those other changes make sense?

I think your changes make sense! 👍

@jeherve jeherve removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 11, 2020
@jeherve jeherve added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Feb 11, 2020
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, even with long strings:
image

@jeherve jeherve added [Status] Needs Design Review Design has been added. Needs a review! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 11, 2020
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again, @coleshaw !

@keoshi keoshi added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Design Review Design has been added. Needs a review! labels Feb 11, 2020
@jeherve jeherve merged commit 77a59d1 into Automattic:master Feb 11, 2020
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 11, 2020
jeherve added a commit that referenced this pull request Feb 11, 2020
@coleshaw coleshaw deleted the update/dashboard-widget-akismet-protect branch February 12, 2020 02:00
jeherve added a commit that referenced this pull request Feb 24, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Protect Also known as Brute Force Attack Protection [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. General [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Widget: confusing UI when only one of Akismet / Protect is enabled
5 participants