Mobile Apps: completely remove the edit post link when in app #14514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wordpress-mobile/WordPress-iOS#13314 This issue was introduced in #12867. The original goal of this change was to to hide the Edit Post link whenever you would access your site via the mobile app's in-app browser. To hide the Edit Post link, we originally opted to hook into the edit_post_link filter. While this works, it only changes the string returned for the Edit Post link itself. It does not account for any "before" or "after" parameters that may be passed when calling the edit_post_link function; those are not part of the filter: https://github.com/WordPress/WordPress/blob/001ffe81fbec4438a9f594f330e18103d21fbcd7/wp-includes/link-template.php#L1439 Instead, let's shortcircuit that link earlier, by hooking into the get_edit_post_link filter. If that filter is set to return an empty string, the edit_post_link function will return early: https://github.com/WordPress/WordPress/blob/001ffe81fbec4438a9f594f330e18103d21fbcd7/wp-includes/link-template.php#L1420
jeherve
added
[Type] Bug
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: February 11, 2020. |
designsimply
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
LGTM! 
I tested using the Twenty Twenty theme with the code change applied and I was able to see that the edit link and the edit icon were both removed from Webviews in WPiOS 14.1.0.0 TestFlight beta on iPhone 6S iOS 13.3.
| Before | After |
|---|---|
 |
 |
I also verified that I can still see the edit link when viewing the post from Safari directly while logged in as an admin on the site.
dereksmart
approved these changes
Feb 12, 2020
matticbot
added
[Status] Needs Changelog
and removed
[Status] Needs Review
jeherve
added a commit
that referenced
this pull request
Feb 25, 2020
* 8.3 release: changelog * Changelog: add #14516 * Changelog: add #14574 * Bring in changes from 8.2.1 and 8.2.2 * Update stable version * Bring in 8.2.3 changes * Changelog: add #14714 * Changelog: add #14639 * Changelog: add #14678 * Changelog: add #14673 * Changelog: add #14687 * Changelog: add #14704 * Changelog: add #14702 * Changelog: add #14541 * Changelog: add #14657 * Changelog: add #14622 * Changelog: add #14582 * Changelog: add #14638 * Changelog: add #14633 * Changelog: add #14571 * Changelog: add #14592 * Changelog: add #14539 * Changelog: add #14514 * Changelog: add #14643 * Changelog: add #14494 * Changelog: add #13739 * Changelog: add #14707 * Changelog: add #14736 * Changelog: add #14706 * Changelog: add #14730 * Changelog: add #14685 * Changelog: add #14727 * Changelog: add #14711 * Changelog: add #14742 * Changelog: add #14746 * Changelog: add #14725 * Changelog: add #13999 * Changelog: add #14740 * Changelog: add #14759 * Changelog: add #14703 * Changelog: add #14753 * Changelog: add #14754 * Changelog: add #14645 * Cahngelog: add #14599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/WordPress-iOS#13314
Changes proposed in this Pull Request:
This issue was introduced in #12867.
The original goal of this change was to to hide the Edit Post link
whenever you would access your site via the mobile app's in-app browser.
To hide the Edit Post link, we originally opted to hook into the edit_post_link filter.
While this works, it only changes the string returned for the Edit Post link itself.
It does not account for any "before" or "after" parameters that may be passed
when calling the edit_post_link function; those are not part of the filter:
https://github.com/WordPress/WordPress/blob/001ffe81fbec4438a9f594f330e18103d21fbcd7/wp-includes/link-template.php#L1439
Instead, let's shortcircuit that link earlier, by hooking into the get_edit_post_link filter.
If that filter is set to return an empty string, the edit_post_link function will return early:
https://github.com/WordPress/WordPress/blob/001ffe81fbec4438a9f594f330e18103d21fbcd7/wp-includes/link-template.php#L1420
Matching WordPress.com reference: D38302-code
Testing instructions:
wordpress/3.1:Proposed changelog entry for your changes: