Skip to content

Map Block: On select, only show the Add Marker UI if there are no markers #14687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2020
Merged

Map Block: On select, only show the Add Marker UI if there are no markers #14687

merged 1 commit into from
Feb 17, 2020

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Feb 14, 2020

Fixes #11870

Changes proposed in this Pull Request:

  • When selecting a Map block, only show the Add Marker UI if there are no existing markers.

Props @jeffersonrabb for the solution!

Testing instructions:

  • Open the editor and add two Map blocks.
  • Select the first map: make sure you are prompted to add a marker.
  • Add a marker.
  • Leave the second map without markers.
  • Save and reload the editor.
  • Select the map with a marker: make sure you are not prompted to add a new marker. You should still be able to add them via the Add Marker toolbar button.
  • Select the map without markers: make sure you are prompted to add a marker.

Proposed changelog entry for your changes:

  • Map Block: On select, only show the Add Marker UI if there are no markers.

@Copons Copons added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Map labels Feb 14, 2020
@Copons Copons requested review from a team February 14, 2020 17:51
@Copons Copons self-assigned this Feb 14, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello Copons! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38935-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 17, 2020.
Scheduled code freeze: February 10, 2020

Generated by 🚫 dangerJS against 70b88cc

pento
pento approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 This is a nice little fix, works for me!

@jeherve jeherve added this to the 8.3 milestone Feb 17, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 17, 2020
@Copons Copons merged commit c0a089c into master Feb 17, 2020
@Copons Copons deleted the fix/11870-map-unnecessary-add-marker branch February 17, 2020 14:44
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 17, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14687
afac366
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

+1 more reviewer

@pento pento pento approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Copons Copons

Labels
[Block] Map [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.

Map Block: Reusable block with markers steals focus
5 participants
@Copons @matticbot @jetpackbot @pento @jeherve