Skip to content

Conversation

kwight
Copy link
Contributor

@kwight kwight commented Jan 29, 2020

Only display the dismiss button in a JITM if is_dismissible is truthy. This will be the default setting for messages in the engine.

This will allow JITMs to be defined without a dismiss button, meaning users will continue to see the JITM until clicking on a CTA. The use-case is notices such as accepting new Terms of Service: we want the user to explicitly click the "Accept" CTA, or continue to see the JITM until new terms come into effect.

Screen Shot 2020-01-29 at 1 56 06 PM

Is this a new feature or does it add/remove features to an existing part of Jetpack?

See: p58i-8v7-p2

Testing instructions:

  • On a WP.com sandbox, create a new test JITM in jitm-engine.php with a ->is_dismissible( false ) property and high priority.
  • Sandbox the API, apply D38330-code, and load your JP site's valid JITM target page.
  • Verify the JITM displays without a dismiss X on the right side.
  • Remove the ->is_dismissible property, reload, and verify the JITM displays the dismiss button by default.

Proposed changelog entry for your changes:

  • Allow hiding the dismiss button in JITMs.

@kwight kwight requested a review from a team January 29, 2020 21:36
@jetpackbot
Copy link
Collaborator

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 0797f55

@kwight kwight self-assigned this Jan 29, 2020
@kwight kwight added [Status] Needs Review This PR is ready for review. [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. labels Jan 29, 2020
@gwwar
Copy link
Contributor

gwwar commented Jan 29, 2020

@kwight I'll check in with Jenny to see if we need to hide the dismiss

@jeherve jeherve added this to the 8.3 milestone Jan 30, 2020
@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Jan 30, 2020
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well in my tests.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 30, 2020
@kwight kwight merged commit 8e6df97 into master Jan 30, 2020
@kwight kwight deleted the update/jitm-remove-dismiss branch January 30, 2020 17:05
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 30, 2020
jeherve added a commit that referenced this pull request Feb 11, 2020
jeherve added a commit that referenced this pull request Feb 24, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants