-
Notifications
You must be signed in to change notification settings - Fork 833
JITMs: Allow JITMs to not have a dismiss button. #14516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is an automated check which relies on |
@kwight I'll check in with Jenny to see if we need to hide the dismiss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well in my tests.
* 8.3 release: changelog * Changelog: add #14516 * Changelog: add #14574 * Bring in changes from 8.2.1 and 8.2.2 * Update stable version * Bring in 8.2.3 changes * Changelog: add #14714 * Changelog: add #14639 * Changelog: add #14678 * Changelog: add #14673 * Changelog: add #14687 * Changelog: add #14704 * Changelog: add #14702 * Changelog: add #14541 * Changelog: add #14657 * Changelog: add #14622 * Changelog: add #14582 * Changelog: add #14638 * Changelog: add #14633 * Changelog: add #14571 * Changelog: add #14592 * Changelog: add #14539 * Changelog: add #14514 * Changelog: add #14643 * Changelog: add #14494 * Changelog: add #13739 * Changelog: add #14707 * Changelog: add #14736 * Changelog: add #14706 * Changelog: add #14730 * Changelog: add #14685 * Changelog: add #14727 * Changelog: add #14711 * Changelog: add #14742 * Changelog: add #14746 * Changelog: add #14725 * Changelog: add #13999 * Changelog: add #14740 * Changelog: add #14759 * Changelog: add #14703 * Changelog: add #14753 * Changelog: add #14754 * Changelog: add #14645 * Cahngelog: add #14599
Only display the dismiss button in a JITM if
is_dismissible
is truthy. This will be the default setting for messages in the engine.This will allow JITMs to be defined without a dismiss button, meaning users will continue to see the JITM until clicking on a CTA. The use-case is notices such as accepting new Terms of Service: we want the user to explicitly click the "Accept" CTA, or continue to see the JITM until new terms come into effect.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
See: p58i-8v7-p2
Testing instructions:
jitm-engine.php
with a->is_dismissible( false )
property and high priority.X
on the right side.->is_dismissible
property, reload, and verify the JITM displays the dismiss button by default.Proposed changelog entry for your changes: