Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop REST API Log entries from being synced #14638

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

mdbitz
Copy link
Contributor

@mdbitz mdbitz commented Feb 11, 2020

REST API Log (https://wordpress.org/plugins/wp-rest-api-log/) saves api requests/responses to the Post Table using a custom post-type. This data is not for front end consumption or to power activity. When used on a site it can lead to 100s/1000s of sync actions in a short time that can delay editorial user actions from being processed.

This blacklists the custom post-type so these logs are not sent to WP.com for processing.

Changes proposed in this Pull Request:

  • Blacklist the 'wp-rest-api-log' post_type so they do not get into the sync queue.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Removes 'wp-rest-api-log' content from syncing to WP.com

Testing instructions:

  • Before Patch
  • Install the REST API Log Plugin
  • Perform various REST API calls to the site
  • Verify 'wp-rest-api-log' posts are being synced to WP.com
  • Apply Patch
  • Perform various REST API calls to the site
  • Verify 'wp-rest-api-log' posts are not being synced to WP.com

Proposed changelog entry for your changes:

  • Increase reliability of internal sync by not sending wp-rest-api-log posts

@mdbitz mdbitz requested a review from a team as a code owner February 11, 2020 14:58
@mdbitz mdbitz self-assigned this Feb 11, 2020
@mdbitz mdbitz added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Feb 11, 2020
@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Feb 11, 2020
@mdbitz mdbitz added this to the 8.3 milestone Feb 11, 2020
@mdbitz
Copy link
Contributor Author

mdbitz commented Feb 11, 2020

Rocco note you can see the details on this in 2671866-z and also 0/1157114176685490/1161409087227617-a

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Feb 11, 2020
@jetpackbot
Copy link

Warnings
⚠️

pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against d3d63b1

@roccotripaldi roccotripaldi added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 11, 2020
@mdbitz mdbitz merged commit adc512f into master Feb 11, 2020
@mdbitz mdbitz deleted the add/sync-rest-api-log-blacklist branch February 11, 2020 19:29
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 11, 2020
@jeherve jeherve removed the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Feb 14, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants