Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vanilla JS instead of jQuery for the Cookies & Consents widget #14753

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Feb 21, 2020

  • No expected change in functionality.
  • Uses vanilla JS instead of jQuery

Is this a new feature or does it add/remove features to an existing part of Jetpack?

This isn't a new feature, it only modifies an existing feature.

Testing instructions:

  1. In the Customizer, add a Cookies & Consents Banner widget to a sidebar

  2. Exit the Customizer

  3. Expected: the widget appears at the bottom

  4. Expected: clicking 'Close and accept' dismisses it
    cookies-conte

  5. Delete the eucookielaw cookie from the browser

  6. In the Customizer, change some of the widget options. Like 'after the user scrolls the page.'

  7. Ensure the widget works as expected

Proposed changelog entry for your changes:

  • Use vanilla JavaScript in the Cookies and Consents widget

Remove 'jquery' as a dependency,
and use vanilla JS.
@kienstra kienstra requested a review from a team as a code owner February 21, 2020 09:39
@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 94756c6

@kienstra kienstra added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Feb 21, 2020
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Focus] Performance labels Feb 21, 2020
@jeherve jeherve added this to the 8.3 milestone Feb 21, 2020
@kraftbj kraftbj self-requested a review February 24, 2020 18:35
@kraftbj
Copy link
Contributor

kraftbj commented Feb 24, 2020

Reviewed in Chrome/Firefox.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 24, 2020
@dereksmart dereksmart merged commit 7b693fa into master Feb 24, 2020
@dereksmart dereksmart deleted the add/cookies-consent-vanilla-js branch February 24, 2020 20:24
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 24, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extra Sidebar Widgets [Focus] Performance [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants