Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Block: Fix the map theme picker buttons #14707

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Map Block: Fix the map theme picker buttons #14707

merged 2 commits into from
Feb 18, 2020

Conversation

pento
Copy link
Contributor

@pento pento commented Feb 17, 2020

Core is overriding the border-radius of the map theme buttons, so the first and last don't appear round, like they should.

Fixes #14701.

Changes proposed in this Pull Request:

  • CSS fix for map block theme buttons.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Bug fix.

Testing instructions:

  • Open the block editor.
  • Insert a map block.
  • Check that the map theme buttons are all round.

Screenshots

Before

image

After

Proposed changelog entry for your changes:

  • Map Block: Fix the styling of the map theme buttons.

@pento pento added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Map labels Feb 17, 2020
@pento pento added this to the 8.3 milestone Feb 17, 2020
@pento pento requested review from simison and a team February 17, 2020 06:15
@pento pento requested a review from a team as a code owner February 17, 2020 06:15
@pento pento self-assigned this Feb 17, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello pento! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38981-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Feb 17, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against b2b1e62

simison
simison previously approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but looking good! Just a small optional suggestion.

Thanks for fixing it!

Copons
Copons previously approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@Copons Copons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Mikael's suggestion, but otherwise this LGTM!

jeherve
jeherve previously approved these changes Feb 17, 2020
View reviewed changes
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 17, 2020
@pento pento dismissed stale reviews from jeherve, Copons, and simison via b2b1e62 February 17, 2020 23:37
@matticbot
Copy link
Contributor

pento, Your synced wpcom patch D38981-code has been updated.

@pento pento added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 17, 2020
@pento
Copy link
Contributor Author

pento commented Feb 17, 2020

Thanks for the feedback, I've implemented it. If someone on @Automattic/jetpack-crew could please green light it again (or just merge it, if I'm not around), we can wrap this one up. 🙂

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 18, 2020
@pento pento merged commit a47bc73 into master Feb 18, 2020
@pento pento deleted the fix/14701-map-theme-buttons branch February 18, 2020 22:13
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 18, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14707
ed37173
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@Copons Copons Copons approved these changes

@simison simison simison left review comments

Assignees

@pento pento

Labels
[Block] Map [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.

Map block: style picker square instead of round
6 participants
@pento @matticbot @jetpackbot @simison @jeherve @Copons