Hotfixes release for sprint ending 2021-04-26#3115
Merged
bjester merged 76 commits intolearningequality:hotfixesfrom Apr 26, 2021
Merged
Hotfixes release for sprint ending 2021-04-26#3115bjester merged 76 commits intolearningequality:hotfixesfrom
bjester merged 76 commits intolearningequality:hotfixesfrom
Conversation
Adding dots between languages on sign-in page
- Removes PrimaryDialog from ChannelItem.vue as the modal handling the deletion pop-up. - Wraps the <VCard> with a <div> so that KModal can live outside of the hierarchy of the <VCard>, which wraps internals in an <a> tag resulting in clicking the action buttons in KModal following that <a> tag.
…names Rename RouterNames -> RouteNames
Cascade latest release into develop
Fix a linter issue (RouterNames -> RouteNames)
…v-dependencies Add flower to dev dependencies
To make migration to KModal simpler - Remove props that are not used from anywhere - Remove logic related to copying or moving as `ProgressModal` is not used for these operations anymore - Remove `showProgressModal` data that is used only in v-model of `ProgressModal`. `ProgressModal` doesn't use it at all to decide if it should be displayed and calculates these criteria internally instead.
Also required moving ChannelTokenModal usage in ChannelItem such that it is rendered outside of the active wrapping DOM element so that clicking the Close button on KModal doesn't click behind it too
…edresourcestab Replace VDialog with KModal in "Related resources tab"
…essmodal Migrate ProgressModal to KDS
# Conflicts: # contentcuration/contentcuration/frontend/channelEdit/views/progress/ProgressModal.vue # contentcuration/contentcuration/frontend/channelEdit/views/progress/__tests__/progressModal.spec.js
…velop Master into develop cascade merge
Make ContentNode filter_edit_queryset consistent with other methods.
…table Hotfixes to unstable
…date Clean up and consolidate permissions.
Reinstate synchronous channel size calculation with lower threshold, and resolve misc task related issues
…log-faq Update 'customContentAnswer' for catalog FAQ
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/npm/ssri/releases) - [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md) - [Commits](npm/ssri@v6.0.1...v6.0.2) Signed-off-by: dependabot[bot] <support@github.com>
…abot/npm_and_yarn/ssri-6.0.2 Bump ssri from 6.0.1 to 6.0.2
…publishing-channel-modal Add editing permissions condition to view/display Publish Modal
…nsivedialog-savedsearchesmodal KDS to Studio: Replace ResponsiveDialog by KModal in SavedSearchesModal
…nel_editors Catch duplicate editor assignment for newly created channels.
Codecov Report
@@ Coverage Diff @@
## hotfixes #3115 +/- ##
============================================
+ Coverage 80.80% 86.12% +5.31%
============================================
Files 281 305 +24
Lines 12659 16459 +3800
============================================
+ Hits 10229 14175 +3946
+ Misses 2430 2284 -146
Continue to review full report at Codecov.
|
rtibbles
approved these changes
Apr 26, 2021
Member
|
Today status on the
|
Member
Author
|
@radinamatic The scope of the changes for #3100 is larger than just fixing #3071. Yes it was intentional that all scenarios are for non-ricecooker channels as the changes in the PR affect permission handling, which isn't linearly connected with any single feature. So the QA scenarios were focused on ensuring regressions against potential permission related bugs |
Member
|
Fair enough, @bjester, it would be good to add this sort of reasoning in the QA Focus in the future 🙏🏽 |
Member
Author
|
@radinamatic Yes it was your own feedback that led us to start adding QA Focus since the issue may not wholly describe the changes that were made, or make it clear how to verify against regressions of the change. So I would say the reasoning for any QA Focus is to regression test features that may be affected by the PR's changes. |
Member
|
Let's recap:
|
Member
Member
Author
|
I was able to stage a channel through a sushi chef and then deploy it. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
View staged channel summary 1
Copy channel token from channel edit page
Sync channel
Publish channel as admin
Open private channel without any permission
Footnotes:
QA Scenarios
Sign-in page
Save a search
View content library FAQ
View staged channel summary 1
View related resources infographic
Add a channel editor
View-only channel doesn't show publishing modal
Publish channel as admin
Open private channel without any permission