KDS to Studio: Replace ResponsiveDialog by KModal in SavedSearchesModal

[MisRob]

Summary

Description of the change(s) you made

Replace ResponsiveDialog by KModal in SavedSearchesModal

Manual verification steps performed

1. Open the channel editor page for a channel that you can edit
2. Click "ADD" dropdown button in the upper right corner
3. Select "Import from channels"
4. Type a search string to search input and click "SEARCH" button
5. Click "View saved searches" (to see some searches in "Saved searches" modal, you can click "Save search" before opening the modal)

Screenshots

Before	After

Does this introduce any tech-debt items?

Nothing that I am aware of regarding Studio code.
I've discovered a bug in KDS that has been reported here.

---

Reviewer guidance

How can a reviewer test these changes?

Please follow "Manual verification steps"

Are there any risky areas that deserve extra testing?

Please check that you can edit and remove saved searches

References

Part of learningequality/kolibri-design-system#157

---

Contributor's Checklist

PR process:

• If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
• If this includes an internal dependency change, a link to the diff is provided
• The docs label has been added if this introduces a change that needs to be updated in the user docs?
• If any Python requirements have changed, the updated requirements.txt files also included in this PR
• Opportunities for using Google Analytics here are noted
• Migrations are safe for a large db

Studio-specifc:

• All user-facing strings are translated properly
• The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
• All UI components are LTR and RTL compliant
• Views are organized into pages, components, and layouts directories as described in the docs
• Users' storage used is recalculated properly on any changes to main tree files
• If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Any new interactions have been added to the QA Sheet
• Critical and brittle code paths are covered by unit tests

---

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[MisRob]

I haven't replaced MessageDialog and EditSearchModal with KModal because @marcellamaki already has some work in progress related to that.

[marcellamaki]

This looks good to me! Nice work Misha :)

[pcenov]

Tested today at https://hotfixes.studio.learningequality.org/ and the Saved searches modal is displayed correctly.
I've reported separately the following 2 issues:
#3117 - Saved searches - My saved search gets duplicated
#3118 - Saved searches - The entered search term is not updated after applying a saved search

Currently the saved searches are not the same for my different channels for example in Channel A I might have Search 1 and Search 2 while in Channel 2 I might have no saved searches at all or totally different saved searches. Is this intentional?

[radinamatic]

Currently the saved searches are not the same for my different channels for example in Channel A I might have Search 1 and Search 2 while in Channel 2 I might have no saved searches at all or totally different saved searches. Is this intentional?

This does not seem to be the case on my side, the same list of all my saved searches (plus the duplicates 😛) appears in all the channels.

[pcenov]

Currently the saved searches are not the same for my different channels for example in Channel A I might have Search 1 and Search 2 while in Channel 2 I might have no saved searches at all or totally different saved searches. Is this intentional?

This does not seem to be the case on my side, the same list of all my saved searches (plus the duplicates 😛) appears in all the channels.

Yeah, I'm not able to replicate that issue today as well. How bizarre... :)