Add flower to dev dependencies#2958
Merged
rtibbles merged 4 commits intolearningequality:developfrom Feb 17, 2021
Merged
Conversation
f0a9e26 to
07a4cdc
Compare
MisRob
commented
Feb 17, 2021
| git+https://github.com/someshchaturvedi/customizable-django-profiler.git#customizable-django-profiler | ||
| tabulate==0.8.2 | ||
| fonttools | ||
| flower==0.9.4 |
Member
Author
There was a problem hiding this comment.
I specified this version because when I didn't do it, I was getting this error during compilation:
Tried: 0.0.1, 0.0.2, 0.0.3, 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 0.0.9, 0.0.10, 0.0.11, 0.0.12, 0.0.13, 0.0.14, 0.0.15, 0.0.16, 0.0.17, 0.0.18, 0.0.19, 0.0.20, 0.0.21, 0.1.0, 0.1.1, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 0.4.1, 0.4.2, 0.5.0, 0.6.0, 0.7.0, 0.7.1, 0.8.0, 0.8.0, 0.9.0, 0.9.0
There are incompatible versions in the resolved dependencies:
prometheus-client==0.7.1 (from -c requirements.txt (line 66))
prometheus-client==0.8.0 (from flower==0.9.7->-r requirements-dev.in (line 42))
I didn't want to touch production dependencies in this PR. Flower 0.9.4 is the newest version that worked well with our current dependencies. Is this approach okay?
Member
Author
|
|
Codecov Report
@@ Coverage Diff @@
## develop #2958 +/- ##
========================================
Coverage 85.53% 85.53%
========================================
Files 299 299
Lines 15827 15827
========================================
Hits 13538 13538
Misses 2289 2289 Continue to review full report at Codecov.
|
rtibbles
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Flower to dev dependencies and mention that we have it available in README.
@aronasorman When I run
pip-compile, it also changed other dependencies' format (maybe it's because I am using the newest version?) Is it okay? To make the review easier, I runpip-compileon the original requirements-dev.in without adding any new updates and committed the diff. Then I added theflowerpackage to requirements, recompiled them, and committed this change in another commit.Issue Addressed
I hope this will make locating this tool easier for developers who are not so familiar with backend tooling like me. Also, I noticed that we actually run flower already as part of services command so I assumed that it would work, and it took me a while to figure out that it wasn't working just due to a missing dependency.
Steps to Test
pip install -r requirements-dev.txtyarn run services