Skip to content

Add missing parts of ProgressModal specs and remove setMethods#3002

Merged
rtibbles merged 1 commit intolearningequality:developfrom
MisRob:progress-modal-specs
Mar 8, 2021
Merged

Add missing parts of ProgressModal specs and remove setMethods#3002
rtibbles merged 1 commit intolearningequality:developfrom
MisRob:progress-modal-specs

Conversation

@MisRob
Copy link
Member

@MisRob MisRob commented Mar 2, 2021

Summary

Description of the change(s) you made


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for improving our tests, @MisRob 😄

@rtibbles
Copy link
Member

rtibbles commented Mar 8, 2021

Thank you! I tried to merge these as best I could, but I think some of it was just missing from develop.

@rtibbles rtibbles merged commit b971d5e into learningequality:develop Mar 8, 2021
@MisRob
Copy link
Member Author

MisRob commented Mar 8, 2021

No worries @rtibbles, I had those TODOs prepared there because I expected that there would be a need to go back after we merge branches - I needed to wait for merging @marcellamaki's work to be able to finish it.

@MisRob MisRob deleted the progress-modal-specs branch March 15, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants