Add missing parts of ProgressModal specs and remove setMethods#3002
Merged
rtibbles merged 1 commit intolearningequality:developfrom Mar 8, 2021
Merged
Add missing parts of ProgressModal specs and remove setMethods#3002rtibbles merged 1 commit intolearningequality:developfrom
rtibbles merged 1 commit intolearningequality:developfrom
Conversation
marcellamaki
approved these changes
Mar 8, 2021
Member
marcellamaki
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks for improving our tests, @MisRob 😄
Member
|
Thank you! I tried to merge these as best I could, but I think some of it was just missing from develop. |
Member
Author
|
No worries @rtibbles, I had those TODOs prepared there because I expected that there would be a need to go back after we merge branches - I needed to wait for merging @marcellamaki's work to be able to finish it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
setMethodsfrom tests introduced by merge (I removed it from the rest of the tests in Migrate ProgressModal to KDS #2968, explained in detail here)Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)