KDS to Studio: KModal on staging tree page#3004
Merged
MisRob merged 2 commits intolearningequality:developfrom Mar 23, 2021
Merged
KDS to Studio: KModal on staging tree page#3004MisRob merged 2 commits intolearningequality:developfrom
MisRob merged 2 commits intolearningequality:developfrom
Conversation
marcellamaki
approved these changes
Mar 22, 2021
Member
marcellamaki
left a comment
There was a problem hiding this comment.
Hi @MisRob - I am so sorry that I missed this review request. I went over it this morning and it looks good to me. Thank you for your very excellent steps, as always. Since this was actually my first time using ricecooker, it was very helpful, and I learned something new 😄 Nice work!
Member
Author
|
Thank you, @marcellamaki, no worries, it's been open for a while but it's part of the current sprint. I would yell on Slack if it'd be a high priority :) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Use KModal instead of VDialog on the staging tree page and related updates.
Manual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
Nothing that I am aware of.
Reviewer guidance
How can a reviewer test these changes?
Follow the manual verifications steps above.
If you don't have a channel with a staging tree available for testing locally, you can create one in the following way:
for book in books[:5]:STUDIO_URLenvironment variable to your local Studio instance (e.g.export STUDIO_URL=http://127.0.0.1:8080/)References
Part of learningequality/kolibri-design-system#156
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specific:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)