Skip to content

KDS to Studio: KModal on staging tree page#3004

Merged
MisRob merged 2 commits intolearningequality:developfrom
MisRob:kds-kmodal-channeledit-stagingtreepage
Mar 23, 2021
Merged

KDS to Studio: KModal on staging tree page#3004
MisRob merged 2 commits intolearningequality:developfrom
MisRob:kds-kmodal-channeledit-stagingtreepage

Conversation

@MisRob
Copy link
Member

@MisRob MisRob commented Mar 3, 2021

Summary

Description of the change(s) you made

Use KModal instead of VDialog on the staging tree page and related updates.

Manual verification steps performed

  1. Go to a staging tree page
  2. Open and close summary modal
  3. Open deploy modal and cancel deploy
  4. Open deploy modal and confirm channel deploy

Screenshots (if applicable)

Before After
summary-details-before summary-details-after
deploy-before deploy-after

Does this introduce any tech-debt items?

Nothing that I am aware of.


Reviewer guidance

How can a reviewer test these changes?

Follow the manual verifications steps above.

If you don't have a channel with a staging tree available for testing locally, you can create one in the following way:

  1. Download one of our sushi chefs. I used Let's Read Asia. If you'd like to use it too and don't want to run it a long time, you can modify this line to for book in books[:5]:
  2. Install ricecooker
  3. Change STUDIO_URL environment variable to your local Studio instance (e.g. export STUDIO_URL=http://127.0.0.1:8080/ )
  4. Run the sushi chef with a token obtained from your local Studio
  5. Navigate to the channel's list in Studio and open the channel
  6. Navigate to a staging tree page by clicking on "Updated resources are ready for review " banner

Screenshot from 2021-03-03 12-31-45

References

Part of learningequality/kolibri-design-system#156


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specific:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob changed the title Kds kmodal channeledit stagingtreepage KDS to Studio: KModal on staging tree page Mar 3, 2021
@MisRob MisRob requested a review from marcellamaki March 3, 2021 11:38
@MisRob MisRob marked this pull request as ready for review March 3, 2021 11:38
@MisRob MisRob requested a review from sairina March 3, 2021 11:39
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MisRob - I am so sorry that I missed this review request. I went over it this morning and it looks good to me. Thank you for your very excellent steps, as always. Since this was actually my first time using ricecooker, it was very helpful, and I learned something new 😄 Nice work!

@MisRob
Copy link
Member Author

MisRob commented Mar 23, 2021

Thank you, @marcellamaki, no worries, it's been open for a while but it's part of the current sprint. I would yell on Slack if it'd be a high priority :)

@MisRob MisRob merged commit 92a5c78 into learningequality:develop Mar 23, 2021
@MisRob MisRob deleted the kds-kmodal-channeledit-stagingtreepage branch September 15, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants