Add license and title validation to views.internal::create_nodes#2999
Merged
rtibbles merged 3 commits intolearningequality:developfrom Mar 12, 2021
Merged
Conversation
79e6781 to
e34cc2c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2999 +/- ##
===========================================
+ Coverage 85.74% 85.77% +0.02%
===========================================
Files 298 298
Lines 15843 15876 +33
===========================================
+ Hits 13585 13618 +33
Misses 2258 2258
Continue to review full report at Codecov.
|
rtibbles
approved these changes
Mar 12, 2021
Member
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
views.internal::create_nodes, adds checks to validate the title and license. Sets the new node'scompletefield to false if the checks fail.Manual verification steps performed
(I'm not sure how to test this, since I think this API is only used via Sushi Chef)
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Partially addresses #2806, (does not invalidate nodes based on rest of criteria in
mark_complete.py)