Skip to content

Catch duplicate editor assignment for newly created channels.#3099

Merged
bjester merged 1 commit intolearningequality:unstablefrom
rtibbles:duplicate_channel_editors
Apr 26, 2021
Merged

Catch duplicate editor assignment for newly created channels.#3099
bjester merged 1 commit intolearningequality:unstablefrom
rtibbles:duplicate_channel_editors

Conversation

@rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Catches integrity errors when assigning an editor to a newly created channel
  • Assuming this happens if the same change gets applied twice

Manual verification steps performed

All tests still pass

References

Fixes #3049

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #3099 (40d6466) into unstable (3da1570) will increase coverage by 0.03%.
The diff coverage is 95.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable    #3099      +/-   ##
============================================
+ Coverage     85.71%   85.75%   +0.03%     
============================================
  Files           298      298              
  Lines         15879    15912      +33     
============================================
+ Hits          13611    13645      +34     
+ Misses         2268     2267       -1     
Impacted Files Coverage Δ
...ontentcuration/contentcuration/viewsets/channel.py 79.31% <60.00%> (-0.44%) ⬇️
...contentcuration/tests/views/test_views_internal.py 97.44% <100.00%> (+0.20%) ⬆️
contentcuration/contentcuration/views/internal.py 85.75% <100.00%> (+0.37%) ⬆️
contentcuration/contentcuration/tasks.py 63.25% <0.00%> (+0.53%) ⬆️
...uration/contentcuration/tests/test_urlendpoints.py 95.83% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a5c78...40d6466. Read the comment docs.

@bjester bjester merged commit 27e7791 into learningequality:unstable Apr 26, 2021
@pcenov
Copy link
Member

pcenov commented Apr 27, 2021

Tested at https://hotfixes.studio.learningequality.org/ that I cannot invite the same email twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IntegrityError: duplicate key value violates unique constraint "contentcuration_channel_editors_channel_id_bfb659...

3 participants