Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate evohome, cache access tokens #24491

Merged
merged 29 commits into from
Jul 7, 2019
Merged

Migrate evohome, cache access tokens #24491

merged 29 commits into from
Jul 7, 2019

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Jun 12, 2019 •
edited
Loading

Breaking Change:

Those migrating from honeywell to evohome will lose higher-precision temperatures (was 0.1C, now 0.5 for climate, and 1.0 for water_heater).

Description:

This is a large PR , which requires/includes:

  • Cache access tokens to prevent exceeding (recently lowered) API limits during restarts of HA (was required for dev/testing for climate-1.0)
  • Adds a water_heater component to the integration (required as this support has been removed in Migrate honeywell to new climate schema #24257)
  • Bump client library (fixes bug preventing use of refresh tokens as above)
  • Fix a bug where zone operating mode was mis-reported
  • Minor refactoring (see below)

Note: Without water_heater support, evohome is not suitable for those switching from honeywell (see #23469).

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable): Unchanged

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned zxdavb Jun 12, 2019
@zxdavb zxdavb requested a review from a team as a code owner June 12, 2019 06:26
@zxdavb zxdavb changed the title WIP: Add evohome water_heater, and prepare for climate-1.0 WIP: Add evohome water_heater, prepare for climate-1.0 Jun 12, 2019
@zxdavb
Copy link
Contributor Author

zxdavb commented Jun 12, 2019 •
edited
Loading

@balloob this is WIP - has a lot of debug code, etc., that will be removed before I remove the WIP.

Are you OK with this going through before I submit another PR to migrate evohome? @pvizeli wanted me to do both (and he'd moved the earlier version of the PR across to climate-1.0), but it just wasn't working out for the reasons outlined above in the Description - it wasn't clear back then just how big a PR it was going to be, see #23969)

(I closed the previous PR #23969 only because I tried to rebase base from climate-1.0 to dev & I buggered it. I don't want to give the impression I'm trying to pull a fast one :) )

@balloob
Copy link
Member

balloob commented Jun 13, 2019 •
edited
Loading

Ha, it was more like a drive by comment. I didn't do a full review. Let me know when it's ready and I'll review it 👍 I think that having stuff moved to water heater is a good move, as climate-1 is going to break that stuff most likely and so it becomes a blocker.

@zxdavb zxdavb mentioned this pull request Jun 15, 2019
Closed
@zxdavb zxdavb changed the title WIP: Add evohome water_heater, prepare for climate-1.0 Add evohome water_heater, prepare for climate-1.0 Jul 1, 2019
@zxdavb zxdavb changed the title WIP: Migrate evohome, cache access tokens and add water_heater Migrate evohome, cache access tokens Jul 7, 2019
@zxdavb
Copy link
Contributor Author

zxdavb commented Jul 7, 2019

@balloob This is ready for review - sorry it is so big.

@pvizeli pvizeli merged commit 63bbb85 into home-assistant:climate-1.0 Jul 7, 2019
@zxdavb zxdavb deleted the add_evohome_water_heater branch July 7, 2019 07:41
@zxdavb zxdavb mentioned this pull request Jul 7, 2019
Closed
9 tasks
pvizeli added a commit that referenced this pull request Jul 8, 2019
@pvizeli
Climate 1.0 (#23899)
84cf76b 
* Climate 1.0 / part 1/2/3

* fix flake

* Lint

* Update Google Assistant

* ambiclimate to climate 1.0 (#24911)

* Fix Alexa

* Lint

* Migrate zhong_hong

* Migrate tuya

* Migrate honeywell to new climate schema (#24257)

* Update one

* Fix model climate v2

* Cleanup p4

* Add comfort hold mode

* Fix old code

* Update homeassistant/components/climate/__init__.py

Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>

* Update homeassistant/components/climate/const.py

Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>

* First renaming

* Rename operation to hvac for paulus

* Rename hold mode to preset mode

* Cleanup & update comments

* Remove on/off

* Fix supported feature count

* Update services

* Update demo

* Fix tests & use current_hvac

* Update comment

* Fix tests & add typing

* Add more typing

* Update modes

* Fix tests

* Cleanup low/high with range

* Update homematic part 1

* Finish homematic

* Fix lint

* fix hm mapping

* Support simple devices

* convert lcn

* migrate oem

* Fix xs1

* update hive

* update mil

* Update toon

* migrate deconz

* cleanup

* update tesla

* Fix lint

* Fix vera

* Migrate zwave

* Migrate velbus

* Cleanup humity feature

* Cleanup

* Migrate wink

* migrate dyson

* Fix current hvac

* Renaming

* Fix lint

* Migrate tfiac

* migrate tado

* Fix PRESET can be None

* apply PR#23913 from dev

* remove EU component, etc.

* remove EU component, etc.

* ready to test now

* de-linted

* some tweaks

* de-lint

* better handling of edge cases

* delint

* fix set_mode typos

* apply PR#23913 from dev

* remove EU component, etc.

* ready to test now

* de-linted

* some tweaks

* de-lint

* better handling of edge cases

* delint

* fix set_mode typos

* delint, move debug code

* away preset now working

* code tidy-up

* code tidy-up 2

* code tidy-up 3

* address issues #18932, #15063

* address issues #18932, #15063 - 2/2

* refactor MODE_AUTO to MODE_HEAT_COOL and use F not C

* add low/high to set_temp

* add low/high to set_temp 2

* add low/high to set_temp - delint

* run HA scripts

* port changes from PR #24402

* manual rebase

* manual rebase 2

* delint

* minor change

* remove SUPPORT_HVAC_ACTION

* Migrate radiotherm

* Convert touchline

* Migrate flexit

* Migrate nuheat

* Migrate maxcube

* Fix names maxcube const

* Migrate proliphix

* Migrate heatmiser

* Migrate fritzbox

* Migrate opentherm_gw

* Migrate venstar

* Migrate daikin

* Migrate modbus

* Fix elif

* Migrate Homematic IP Cloud to climate-1.0 (#24913)

* hmip climate fix

* Update hvac_mode and preset_mode

* fix lint

* Fix lint

* Migrate generic_thermostat

* Migrate incomfort to new climate schema (#24915)

* initial commit

* Update climate.py

* Migrate eq3btsmart

* Lint

* cleanup PRESET_MANUAL

* Migrate ecobee

* No conditional features

* KNX: Migrate climate component to new climate platform (#24931)

* Migrate climate component

* Remove unused code

* Corrected line length

* Lint

* Lint

* fix tests

* Fix value

* Migrate geniushub to new climate schema (#24191)

* Update one

* Fix model climate v2

* Cleanup p4

* Add comfort hold mode

* Fix old code

* Update homeassistant/components/climate/__init__.py

Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>

* Update homeassistant/components/climate/const.py

Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>

* First renaming

* Rename operation to hvac for paulus

* Rename hold mode to preset mode

* Cleanup & update comments

* Remove on/off

* Fix supported feature count

* Update services

* Update demo

* Fix tests & use current_hvac

* Update comment

* Fix tests & add typing

* Add more typing

* Update modes

* Fix tests

* Cleanup low/high with range

* Update homematic part 1

* Finish homematic

* Fix lint

* fix hm mapping

* Support simple devices

* convert lcn

* migrate oem

* Fix xs1

* update hive

* update mil

* Update toon

* migrate deconz

* cleanup

* update tesla

* Fix lint

* Fix vera

* Migrate zwave

* Migrate velbus

* Cleanup humity feature

* Cleanup

* Migrate wink

* migrate dyson

* Fix current hvac

* Renaming

* Fix lint

* Migrate tfiac

* migrate tado

* delinted

* delinted

* use latest client

* clean up mappings

* clean up mappings

* add duration to set_temperature

* add duration to set_temperature

* manual rebase

* tweak

* fix regression

* small fix

* fix rebase mixup

* address comments

* finish refactor

* fix regression

* tweak type hints

* delint

* manual rebase

* WIP: Fixes for honeywell migration to climate-1.0 (#24938)

* add type hints

* code tidy-up

* Fixes for incomfort migration to climate-1.0 (#24936)

* delint type hints

* no async unless await

* revert: no async unless await

* revert: no async unless await 2

* delint

* fix typo

* Fix homekit_controller on climate-1.0 (#24948)

* Fix tests on climate-1.0 branch

* As part of climate-1.0, make state return the heating-cooling.current characteristic

* Fixes from review

* lint

* Fix imports

* Migrate stibel_eltron

* Fix lint

* Migrate coolmaster to climate 1.0 (#24967)

* Migrate coolmaster to climate 1.0

* fix lint errors

* More lint fixes

* Fix demo to work with UI

* Migrate spider

* Demo update

* Updated frontend to 20190705.0

* Fix boost mode (#24980)

* Prepare Netatmo for climate 1.0 (#24973)

* Migration Netatmo

* Address comments

* Update climate.py

* Migrate ephember

* Migrate Sensibo

* Implemented review comments (#24942)

* Migrate ESPHome

* Migrate MQTT

* Migrate Nest

* Migrate melissa

* Initial/partial migration of ST

* Migrate ST

* Remove Away mode (#24995)

* Migrate evohome, cache access tokens (#24491)

* add water_heater, add storage - initial commit

* add water_heater, add storage - initial commit

delint

add missing code

desiderata

update honeywell client library & CODEOWNER

add auth_tokens code, refactor & delint

refactor for broker

delint

* Add Broker, Water Heater & Refactor

add missing code

desiderata

* update honeywell client library & CODEOWNER

add auth_tokens code, refactor & delint

refactor for broker

* bugfix - loc_idx may not be 0

more refactor - ensure pure async

more refactoring

appears all r/o attributes are working

tweak precsion, DHW & delint

remove unused code

remove unused code 2

remove unused code, refactor _save_auth_tokens()

* support RoundThermostat

bugfix opmode, switch to util.dt, add until=1h

revert breaking change

* store at_expires as naive UTC

remove debug code

delint

tidy up exception handling

delint

add water_heater, add storage - initial commit

delint

add missing code

desiderata

update honeywell client library & CODEOWNER

add auth_tokens code, refactor & delint

refactor for broker

add water_heater, add storage - initial commit

delint

add missing code

desiderata

update honeywell client library & CODEOWNER

add auth_tokens code, refactor & delint

refactor for broker

delint

bugfix - loc_idx may not be 0

more refactor - ensure pure async

more refactoring

appears all r/o attributes are working

tweak precsion, DHW & delint

remove unused code

remove unused code 2

remove unused code, refactor _save_auth_tokens()

support RoundThermostat

bugfix opmode, switch to util.dt, add until=1h

revert breaking change

store at_expires as naive UTC

remove debug code

delint

tidy up exception handling

delint

* update CODEOWNERS

* fix regression

* fix requirements

* migrate to climate-1.0

* tweaking

* de-lint

* TCS working? & delint

* tweaking

* TCS code finalised

* remove available() logic

* refactor _switchpoints()

* tidy up switchpoint code

* tweak

* teaking device_state_attributes

* some refactoring

* move PRESET_CUSTOM back to evohome

* move CONF_ACCESS_TOKEN_EXPIRES CONF_REFRESH_TOKEN back to evohome

* refactor SP code and dt conversion

* delinted

* delinted

* remove water_heater

* fix regression

* Migrate homekit

* Cleanup away mode

* Fix tests

* add helpers

* fix tests melissa

* Fix nehueat

* fix zwave

* add more tests

* fix deconz

* Fix climate test emulate_hue

* fix tests

* fix dyson tests

* fix demo with new layout

* fix honeywell

* Switch homekit_controller to use HVAC_MODE_HEAT_COOL instead of HVAC_MODE_AUTO (#25009)

* Lint

* PyLint

* Pylint

* fix fritzbox tests

* Fix google

* Fix all tests

* Fix lint

* Fix auto for homekit like controler

* Fix lint

* fix lint
@zxdavb zxdavb mentioned this pull request Jul 9, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@pvizeli pvizeli pvizeli approved these changes

@andrewsayre andrewsayre Awaiting requested review from andrewsayre

@bachya bachya Awaiting requested review from bachya

@rytilahti rytilahti Awaiting requested review from rytilahti

@Adminiuga Adminiuga Awaiting requested review from Adminiuga

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen

@danielperna84 danielperna84 Awaiting requested review from danielperna84

@dgomes dgomes Awaiting requested review from dgomes

@dmulcahey dmulcahey Awaiting requested review from dmulcahey

@fabaff fabaff Awaiting requested review from fabaff

@hunterjm hunterjm Awaiting requested review from hunterjm

@kellerza kellerza Awaiting requested review from kellerza

@ludeeus ludeeus Awaiting requested review from ludeeus

@OttoWinter OttoWinter Awaiting requested review from OttoWinter

@robbiet480 robbiet480 Awaiting requested review from robbiet480

@Swamp-Ig Swamp-Ig Awaiting requested review from Swamp-Ig

Assignees

@zxdavb zxdavb

Labels
cla-signed integration: evohome new-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zxdavb @balloob @MartinHjelmare @pvizeli @homeassistant