Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate coolmaster to climate 1.0 #24967

Merged
merged 3 commits into from
Jul 5, 2019

Conversation

OnFreund
Copy link
Contributor

@OnFreund OnFreund commented Jul 5, 2019

Breaking Change:

Based on the new climate platform, so some functionality is missing. Additionally, off now needs to be defined as part of the supported_modes in config if you override the defaults.

Description:

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@OnFreund OnFreund mentioned this pull request Jul 5, 2019
59 tasks
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit 42d3d12 into home-assistant:climate-1.0 Jul 5, 2019
@lock lock bot locked and limited conversation to collaborators Jul 6, 2019
@OnFreund OnFreund deleted the climate-1.0 branch April 25, 2020 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants