KNX: Migrate climate component to new climate platform #24931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Julius2342, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
marvin-w
changed the title
added 2 commits
July 3, 2019 23:35
| self.device.mode.operation_modes] | ||
|
|
||
| if self.device.supports_on_off: | ||
| _operations[HVAC_MODE_HEAT] = HVAC_MODE_HEAT |
There was a problem hiding this comment.
_operations is a list, right? What do we want to do here?
There was a problem hiding this comment.
Thanks, fixed in https://github.com/home-assistant/home-assistant/pull/24942/files
| _operations[HVAC_MODE_HEAT] = HVAC_MODE_HEAT | ||
| _operations[HVAC_MODE_OFF] = HVAC_MODE_OFF | ||
|
|
||
| return list(filter(None, _operations)) |
There was a problem hiding this comment.
We prefer list comprehension without using filter.
return [op for op in _operations if op is not None]There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Migrate knx climate component to new climate platform.
Description:
I tried to follow the PR description as much as possible.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: