Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for incomfort migration to climate-1.0 #24936

Merged
merged 6 commits into from
Jul 5, 2019
Merged

Fixes for incomfort migration to climate-1.0 #24936

merged 6 commits into from
Jul 5, 2019

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Jul 3, 2019

Breaking Change:

None, but note: WIP

Description:

Minor fixes for the migration of climate component of this integration.

  • corrected type hints
  • minor refactors

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned zxdavb Jul 3, 2019
@zxdavb zxdavb changed the title Fixes for incomfort migration to climate-1.0 WIP: Fixes for incomfort migration to climate-1.0 Jul 3, 2019
@pvizeli
Copy link
Member

pvizeli commented Jul 4, 2019

typing is complete wrong

homeassistant/components/incomfort/climate.py Outdated Show resolved Hide resolved
homeassistant/components/incomfort/climate.py Outdated Show resolved Hide resolved
homeassistant/components/incomfort/climate.py Outdated Show resolved Hide resolved
homeassistant/components/incomfort/climate.py Outdated Show resolved Hide resolved
@zxdavb zxdavb changed the title WIP: Fixes for incomfort migration to climate-1.0 Fixes for incomfort migration to climate-1.0 Jul 4, 2019
@pvizeli pvizeli merged commit da94554 into home-assistant:climate-1.0 Jul 5, 2019
@zxdavb zxdavb deleted the migrate_incomfort_fixes branch July 5, 2019 12:09
@lock lock bot locked and limited conversation to collaborators Jul 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants