Prepare Netatmo for climate 1.0 #24973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jul 5, 2019
| MIN_TIME_BETWEEN_UPDATES = timedelta(seconds=10) | ||
| PRESET_FROST_GUARD = 'frost_guard' | ||
| PRESET_MAX = 'max' | ||
| PRESET_OFF = HVAC_MODE_OFF |
There was a problem hiding this comment.
None will be passed as preset for the off preset.
balloob
reviewed
Jul 5, 2019
| """Return the operation modes list.""" | ||
| return self._operation_list | ||
| """Return the list of available hvac operation modes.""" | ||
| return SUPPORT_HVAC |
There was a problem hiding this comment.
Why do you maintain self._operation_list if you are not using it ?
There was a problem hiding this comment.
True, thanks for the hint.
balloob
approved these changes
Jul 5, 2019
|
I don't think that just setting your preset value to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Prepare the Netatmo climate component for the big Climate-1.0 change in #23899.
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: