Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Climate 1.0: Homematic IP remove away Mode / improve eco mode #24995

Merged
merged 1 commit into from
Jul 7, 2019
Merged

Climate 1.0: Homematic IP remove away Mode / improve eco mode #24995

merged 1 commit into from
Jul 7, 2019

Conversation

SukramJ
Copy link
Contributor

@SukramJ SukramJ commented Jul 6, 2019

Description:

This PR removes the away mode, due to problems with refresh.
Instead the updated upstream lib fixes an issue with eco mode.
This implementation should be more reliable.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@SukramJ SukramJ changed the title Homematic IP remove away Mode / improve eco mode Climate 1.0: Homematic IP remove away Mode / improve eco mode Jul 6, 2019
@pvizeli pvizeli merged commit 69578da into home-assistant:climate-1.0 Jul 7, 2019
@SukramJ SukramJ deleted the HmIP_RemoveAway branch July 7, 2019 06:44
@lock lock bot locked and limited conversation to collaborators Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants