Migrate Homematic IP Cloud to climate-1.0 #24913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukramJ
requested review from
andrewsayre,
andrey-git,
awarecan,
Danielhiversen,
danielperna84,
frenck,
Jc2k,
Kane610,
OttoWinter,
pvizeli,
rytilahti and
a team
as code owners
pvizeli
reviewed
Jul 2, 2019
pvizeli
approved these changes
Jul 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is the initial PR to migrate HmIP climate to 1.0.
PRESET_AWAY and PRESET_ECO should be displayed per device, but these modes cannot be set on a device level. A service to control PRESET_AWAY and PRESET_ECO might be added in a follow up PR.
The HmIP Climate device has a PRESET manual mode. In this mode the set temperature will be used and no temperature profile will be active.
Thats why i added an additional constant.
As far as i could see there is no corresponding ui implementations for hvac_mode and preset_mode, so it is harder to test.
I hope this PR helps.
Checklist:
tox. Your PR cannot be merged unless tests pass