Skip to content

Move some functions from package git to gitrepo #33910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 1, 2025
Merged

Move some functions from package git to gitrepo #33910

merged 17 commits into from
Sep 1, 2025
+32 −23

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 16, 2025

Follow #33874

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 16, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 16, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2025
wxiaoguang
wxiaoguang previously requested changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should stop here.

The design is wrong.

You can't make every function do "for repo" and "for wiki".

Since wiki is also a git repo, it should share the same repo interface as a code repo.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2025
@lunny lunny mentioned this pull request Mar 17, 2025
Merged
@lunny lunny closed this in #33924 Mar 19, 2025
@lunny lunny closed this in a9e8ac0 Mar 19, 2025
@lunny lunny reopened this Mar 19, 2025
@wxiaoguang wxiaoguang dismissed their stale review March 27, 2025 07:34

dismiss

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 27, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2025
wxiaoguang
wxiaoguang reviewed Mar 28, 2025
View reviewed changes
wxiaoguang
wxiaoguang previously requested changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design of StorageRepo is buggy and will cause more abuses or bugs.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Mar 28, 2025
@lunny
Copy link
Member Author

lunny commented Aug 30, 2025

The design of StorageRepo is buggy and will cause more abuses or bugs.

The interface change has been reverted.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Aug 31, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 1, 2025
@lunny lunny added this to the 1.25.0 milestone Sep 1, 2025
@lunny lunny enabled auto-merge (squash) September 1, 2025 18:49
@lunny lunny merged commit 1717af7 into go-gitea:main Sep 1, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 1, 2025
@lunny lunny deleted the lunny/move_initrepository branch September 1, 2025 19:13
hiifong added a commit to hiifong/gitea that referenced this pull request Sep 2, 2025
@hiifong
Merge branch 'main' into squash-merge-msg
1f14255 
* main:
  [skip ci] Updated translations via Crowdin
  Use github.com/mholt/archives replace github.com/mholt/archiver (go-gitea#35390)
  Move some functions from package git to gitrepo (go-gitea#33910)
  Move git config/remote to gitrepo package and add global lock to resolve possible conflict when updating repository git config file (go-gitea#35151)
  Move HasWiki to repository service package (go-gitea#33912)
  Rename UpdateBranch API to RenameBranch API (go-gitea#35374)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 2, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fb54d91 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Use github.com/mholt/archives replace github.com/mholt/archiver (go-gitea#35390)
  Move some functions from package git to gitrepo (go-gitea#33910)
  Move git config/remote to gitrepo package and add global lock to resolve possible conflict when updating repository git config file (go-gitea#35151)
  Move HasWiki to repository service package (go-gitea#33912)
  Rename UpdateBranch API to RenameBranch API (go-gitea#35374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang left review comments

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @techknowlogick @wxiaoguang @hiifong @GiteaBot