Skip to content

Refactor OpenIDConnect to support SSH/FullName sync #34978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 10, 2025
Merged

Refactor OpenIDConnect to support SSH/FullName sync #34978

merged 9 commits into from
Jul 10, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jul 7, 2025 •
edited
Loading

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 7, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jul 7, 2025
Closed
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Jul 7, 2025
This was referenced Jul 7, 2025
Closed
Closed
@wxiaoguang wxiaoguang added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jul 7, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jul 7, 2025 •
edited
Loading

Screenshot:

image

@github-actions github-actions bot added the modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin label Jul 7, 2025
lunny
lunny reviewed Jul 7, 2025
View reviewed changes
@lunny

This comment was marked as off-topic.

Sign in to view
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jul 8, 2025 •
edited
Loading

It seems there’s a bug: when attempting to log in via GitHub, it is incorrectly authenticated as a different user. Both the username and email are different from Github's username and email.

Have you checked your domain (visited domain vs callback domain)? Are they using the same session?

Update: it's said that that bug was caused by incorrect "user.login_source", related to:

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 8, 2025
@wxiaoguang wxiaoguang requested a review from a team July 8, 2025 09:12
@wxiaoguang
Copy link
Contributor Author

@go-gitea/maintainers ready for review, thank you.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 10, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 10, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) July 10, 2025 16:45
@wxiaoguang wxiaoguang disabled auto-merge July 10, 2025 18:03
@wxiaoguang wxiaoguang enabled auto-merge (squash) July 10, 2025 18:09
@wxiaoguang wxiaoguang merged commit a5a3d9b into go-gitea:main Jul 10, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jul 10, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 10, 2025
@wxiaoguang wxiaoguang deleted the fix-oauth2 branch July 10, 2025 18:36
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 11, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a9ed1ec 
* giteaofficial/main:
  Fix updating user visibility (go-gitea#35036)
  Fix git commit committer parsing and add some tests (go-gitea#35007)
  Refactor OpenIDConnect to support SSH/FullName sync (go-gitea#34978)
  Support base64-encoded agit push options (go-gitea#35037)
  Also display "recently pushed branch" alert on PR view (go-gitea#35001)
  Make submodule link work with relative path (go-gitea#35034)
  Update to go 1.24.5 (go-gitea#35031)
  Improve CLI commands (go-gitea#34973)
  Tweak eslint config, fix new issues (go-gitea#35019)

# Conflicts:
#	templates/repo/commits_list.tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Pull user's 'Full Name' attribute from OAuth source automatically set SSH principal for users Import SSH keys via OIDC
4 participants
@wxiaoguang @lunny @hiifong @GiteaBot