Add support for 3D/CAD file formats preview #34794

kerwin612 · 2025-06-20T14:00:08Z

#34775

modules/typesniffer/typesniffer.go

web_src/js/render/3d-viewer.ts

wxiaoguang · 2025-06-20T18:11:46Z

I think we need a pure frontend "render plugin" mechanism

Register "fronend render plugin"
Plugin read page information (for example: file name)
If the plugin is able to render it, read the "raw" content, then replace the "fileview" element.

I don't think we should hard-code too many file types in backend.

…port

package.json

wxiaoguang · 2025-06-26T23:37:08Z

Can we merge "initPdfViewer" into the new framework? I think it can also benefit from the new design.

web_src/css/file-view.css

web_src/js/features/file-view.ts

templates/repo/view_file.tmpl

web_src/js/features/file-view.ts

web_src/js/index.ts

web_src/js/render/plugins/3d-viewer.ts

… into feat/support-preview-3d-file

kerwin612 · 2025-06-27T15:42:31Z

Can we merge "initPdfViewer" into the new framework? I think it can also benefit from the new design.

OK, I will also refactor the PdfViewer.

web_src/js/features/file-view.ts

wxiaoguang · 2025-06-27T16:08:33Z

@silverwind maybe need to completely prevent developers from constructing HTML content by JS. Too many XSS problems. #34794 (review) #34794 (review)

web_src/js/render/plugins/pdf-viewer.ts

wxiaoguang · 2025-06-28T16:22:52Z

Simplified

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2025

github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/dependencies modifies/frontend labels Jun 20, 2025

delvh reviewed Jun 20, 2025

View reviewed changes

modules/typesniffer/typesniffer.go Outdated Show resolved Hide resolved

modules/typesniffer/typesniffer.go Outdated Show resolved Hide resolved

web_src/js/render/3d-viewer.ts Outdated Show resolved Hide resolved

kerwin612 force-pushed the feat/support-preview-3d-file branch from eba2b22 to 057ee0e Compare June 21, 2025 06:16

github-actions bot removed the modifies/go Pull requests that update Go code label Jun 21, 2025

kerwin612 requested review from delvh, lunny and wxiaoguang June 21, 2025 06:17

feat: add plugin-based file rendering system with 3D file preview sup…

448effb

…port

kerwin612 force-pushed the feat/support-preview-3d-file branch from 057ee0e to 448effb Compare June 21, 2025 06:22

wxiaoguang reviewed Jun 21, 2025

View reviewed changes

package.json Show resolved Hide resolved

fix tests error

2e80917

github-actions bot added the modifies/go Pull requests that update Go code label Jun 21, 2025

lunny added this to the 1.25.0 milestone Jun 23, 2025

lunny approved these changes Jun 26, 2025

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2025

Merge branch 'main' into feat/support-preview-3d-file

1296d61