-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Also display "recently pushed branch" alert on PR view #35001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
But GH does not show it on the issues page right? Why should we? |
My thought was mainly because of time tracking. So if you work on something, then go to stop your time tracking, you have the alert close by. I have no strong feelings towards that part however. |
Maybe keep it to the PR page. Issue page with issue pins visible would be quite overloaded imho. |
Two things in my mind:
|
Changed it to only show on the PR page due to popular demand, and also moved the file back to |
This is the current behavior, which I didn't change. Sorry if I made it seem like I removed that functionality in favor of having it only on the PR view, that's not the case! :) |
Ah I wasn't aware. So we show it on:
Is that correct? |
Yep, that covers it! |
Thank you very much for the PR. Your change is good enough. I made some more changes, some ideas are:
So I made some changes that I'd like to do sooner or later in this PR together 😆 🙏 Screenshot (no visual change): |
* giteaofficial/main: Fix updating user visibility (go-gitea#35036) Fix git commit committer parsing and add some tests (go-gitea#35007) Refactor OpenIDConnect to support SSH/FullName sync (go-gitea#34978) Support base64-encoded agit push options (go-gitea#35037) Also display "recently pushed branch" alert on PR view (go-gitea#35001) Make submodule link work with relative path (go-gitea#35034) Update to go 1.24.5 (go-gitea#35031) Improve CLI commands (go-gitea#34973) Tweak eslint config, fix new issues (go-gitea#35019) # Conflicts: # templates/repo/commits_list.tmpl
This commit adds the "You recently pushed to branch X" alert also to PR overview, as opposed to only the repository's home page.
GitHub also shows this alert on the PR list, as well as the home page, which makes sense, since a common flow is:
For step 6, many devs' intuition is to go directly to the pull request page, to open a new PR. However, in current Gitea, this is actually not optimal, since this would require you to enter your PR details manually, and going to the home page would let you take a shortcut, which is unintuitive.
Screenshots:
PR List: