Partially refresh notifications list #35010

anbraten · 2025-07-09T06:43:59Z

This PR prevents full reloads for the notifications list when changing a notifications status (read, unread, pinned).

Currently marking several notifications as read is pretty slow for me as you have to wait for the full page reload to before marking the next entry as read (especially on larger instances or when having a slower connection to them).

as discussed in #33465

Before:

Notifications.-.Gitea_.Git.with.a.cup.of.tea.-.Google.Chrome.2025-07-09.14-29-25.mp4

After:

Notifications.-.Gitea_.Git.with.a.cup.of.tea.-.Google.Chrome.2025-07-09.14-31-12.mp4

Todos / open questions

Should none js systems be supported? Currently added type button so the forms are unused

wxiaoguang · 2025-07-09T07:11:18Z

Could you elaborate what's the goal of this PR and what problem it would fix?

IMO we could:

completely drop the "notification page auto-reload by the Server-sent event" support.
make the notification page reload (full refresh) when navigating between pages, just like issues/PRs and other list pages.

Then everything could be simplified, and user experience is still good.

anbraten · 2025-07-09T07:28:43Z

make the notification page reload (full refresh) when navigating between pages, just like issues/PRs and other list pages.

The goal of the PR is to improve UX when checking notifications. I am using the notifications as my entrypoint for most interactions with Gitea and as something like a ToDo list. Currently marking several notifications as read is pretty slow for me as you have to wait for the full page reload to check the next entry (especially on larger instances or when having a slower connection to them).

wxiaoguang · 2025-07-09T08:37:00Z

Currently marking several notifications as read is pretty slow for me as you have to wait for the full page reload to check the next entry (especially on larger instances or when having a slower connection to them).

Then I think we need to add some checkboxes like GitHub, but not "partially refresh". "partially refresh" won't make noticeable speed-up.

silverwind · 2025-07-09T08:46:48Z

I'm definitely in favor of dropping the (buggy) SSE code. Websocket is the final goal, but I can accept a polling-based approach as an interim solution which should be much easier to implement.

anbraten · 2025-07-09T12:25:19Z

I've fixed the htmx code now, the status post was missing the noredirect parameter.

"partially refresh" won't make noticeable speed-up.

I would say it does. Loading the complete page and assets again is quite a bit slower and lets the browser flicker, so staying at the same position and clicking on one notification after another is no fun. Added a recording to the description that shows how it works using a fast but not instant 4g connection.

routers/web/user/notification.go

templates/user/notification/notification_div.tmpl

web_src/js/features/notification.ts

anbraten · 2025-07-09T14:49:45Z

templates/user/notification/notification_div.tmpl

-						{{if eq .Status 1}}
-							{{ctx.Locale.Tr "notification.no_unread"}}
+		<div id="notification_table">
+			{{range $one := .Notifications}}


Why not keeping notification instead of one?

Using $notification in the code below will make the line unnecessarily long .... we will get:

{{$notification.Repository.FullName}} {{if $notification.Issue}}<span class="text light-3">#{{$notification.Issue.Index}}</span>{{end}}

I think $one.ID is clear enough

web_src/css/user.css

routers/web/user/notification.go

anbraten · 2025-07-09T14:55:33Z

routers/web/user/notification.go

 	pager := context.NewPagination(int(total), perPage, page, 5)
 	if pager.Paginater.Current() < page {
 		ctx.Redirect(fmt.Sprintf("%s/notifications?q=%s&page=%d", setting.AppSubURL, url.QueryEscape(ctx.FormString("q")), pager.Paginater.Current()))
 		return
 	}

-	statuses := []activities_model.NotificationStatus{status, activities_model.NotificationStatusPinned}
+	statuses := []activities_model.NotificationStatus{queryStatus, activities_model.NotificationStatusPinned}


The pinned status would still appear in both lists which is somehow strange IMO. No idea what the best way to improve would be as I am in general not 100% sure how ppl use this. Would it make sense to put pinned entries to the top?

Leave the problem to the future?

web_src/js/features/notification.ts

wxiaoguang · 2025-07-09T15:44:55Z

Done from my side, much more changes than I thought .....

* giteaofficial/main: Fix ListWorkflowRuns OpenAPI response model. (go-gitea#35026) Partially refresh notifications list (go-gitea#35010)

feat: partially load notifications list

8a63806

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2025

github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Jul 9, 2025

fix

65071d5

github-actions bot added the modifies/go Pull requests that update Go code label Jul 9, 2025

fix

a9c914f

github-actions bot removed the modifies/frontend label Jul 9, 2025

anbraten changed the title ~~feat: partially refresh notifications list~~ Partially refresh notifications list Jul 9, 2025

wxiaoguang reviewed Jul 9, 2025

View reviewed changes

routers/web/user/notification.go Outdated Show resolved Hide resolved

improve code

2e4add4

github-actions bot removed the modifies/go Pull requests that update Go code label Jul 9, 2025

wxiaoguang reviewed Jul 9, 2025

View reviewed changes

templates/user/notification/notification_div.tmpl Outdated Show resolved Hide resolved

refactor

138cc99

github-actions bot added modifies/go Pull requests that update Go code modifies/frontend labels Jul 9, 2025

wxiaoguang added 3 commits July 9, 2025 22:20

fix paging

cb0c106

fix redirect

c3247a5

fix SSE ...

45f1d57

wxiaoguang reviewed Jul 9, 2025

View reviewed changes

web_src/js/features/notification.ts Outdated Show resolved Hide resolved

anbraten commented Jul 9, 2025

View reviewed changes

fix htmx process, remove bfcache support

a646b32

wxiaoguang reviewed Jul 9, 2025

View reviewed changes

web_src/js/features/notification.ts Show resolved Hide resolved

wxiaoguang added 2 commits July 9, 2025 23:15

fix empty notice

11443d8

use ts strict type

b0c1110

wxiaoguang marked this pull request as ready for review July 9, 2025 15:44

wxiaoguang added the type/enhancement An improvement of existing functionality label Jul 9, 2025

wxiaoguang added this to the 1.25.0 milestone Jul 9, 2025

lunny approved these changes Jul 9, 2025

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 9, 2025

wxiaoguang approved these changes Jul 10, 2025

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 10, 2025

Merge branch 'main' into htmx-notifications

1712c11

wxiaoguang enabled auto-merge (squash) July 10, 2025 03:55

wxiaoguang merged commit ea809a5 into go-gitea:main Jul 10, 2025
26 checks passed

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 10, 2025

Merge remote-tracking branch 'giteaofficial/main'

8636bf7

* giteaofficial/main: Fix ListWorkflowRuns OpenAPI response model. (go-gitea#35026) Partially refresh notifications list (go-gitea#35010)

wxiaoguang mentioned this pull request Jul 12, 2025

Proposal: drop htmx #35059

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Partially refresh notifications list #35010

Partially refresh notifications list #35010

Uh oh!

anbraten commented Jul 9, 2025 •

edited

Loading

Uh oh!

wxiaoguang commented Jul 9, 2025 •

edited

Loading

Uh oh!

anbraten commented Jul 9, 2025

Uh oh!

wxiaoguang commented Jul 9, 2025

Uh oh!

silverwind commented Jul 9, 2025 •

edited

Loading

Uh oh!

anbraten commented Jul 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anbraten Jul 9, 2025

Uh oh!

wxiaoguang Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

anbraten Jul 9, 2025 •

edited

Loading

Uh oh!

wxiaoguang Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

wxiaoguang commented Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Partially refresh notifications list #35010

Partially refresh notifications list #35010

Uh oh!

Conversation

anbraten commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todos / open questions

Uh oh!

wxiaoguang commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anbraten commented Jul 9, 2025

Uh oh!

wxiaoguang commented Jul 9, 2025

Uh oh!

silverwind commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anbraten commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anbraten Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

anbraten Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wxiaoguang commented Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

anbraten commented Jul 9, 2025 •

edited

Loading

wxiaoguang commented Jul 9, 2025 •

edited

Loading

silverwind commented Jul 9, 2025 •

edited

Loading

anbraten commented Jul 9, 2025 •

edited

Loading

anbraten Jul 9, 2025 •

edited

Loading