Skip to content

Add a login/login-name/username disambiguation to affected endpoint parameters and response/request models #34901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2025

Conversation

AlexMaryW
Copy link
Contributor

Issue: link

Changes introduced: I have clarified the problematic terms (login, login_name, and username) in all affected endpoints.

The changes were made to relevant:

  • HTTP endpoint parameters' descriptions
  • response/request models' fields

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 29, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jun 29, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 29, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 30, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 30, 2025
@lunny lunny merged commit f74a136 into go-gitea:main Jun 30, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jun 30, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 30, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 30, 2025
* giteaofficial/main:
  Add a `login`/`login-name`/`username` disambiguation to affected endpoint parameters and response/request models (go-gitea#34901)
  Improve tags list page (go-gitea#34898)
  [skip ci] Updated translations via Crowdin
  docs: fix typo in pull request merge warning message text (go-gitea#34899)
  Refactor container package (go-gitea#34877)
  [skip ci] Updated translations via Crowdin
  Fix project column edit (go-gitea#34890)
  Upgrade htmx to 2.0.6 (go-gitea#34887)
  Optimize flex layout of release attachment area (go-gitea#34885)
  Improve `labels-list` rendering (go-gitea#34846)
  enforce explanation for necessary nolints and fix bugs (go-gitea#34883)
  Fix a regression when refactoring fork list (go-gitea#34879)
  enforce nolint scope (go-gitea#34851)
bdruth added a commit to bdruth/gitea that referenced this pull request Jul 4, 2025
…h/gitea into feature/enhanced-workflow-runs-api

* 'feature/enhanced-workflow-runs-api' of github.com:bdruth/gitea:
  [skip ci] Updated translations via Crowdin
  Follow file symlinks in the UI to their target (go-gitea#28835)
  Fix issue filter (go-gitea#34914)
  Fix: RPM package download routing & missing package version count (go-gitea#34909)
  Add support for 3D/CAD file formats preview (go-gitea#34794)
  Add a `login`/`login-name`/`username` disambiguation to affected endpoint parameters and response/request models (go-gitea#34901)
  Improve tags list page (go-gitea#34898)
  [skip ci] Updated translations via Crowdin
  docs: fix typo in pull request merge warning message text (go-gitea#34899)
  Refactor container package (go-gitea#34877)
  [skip ci] Updated translations via Crowdin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants