Remove deprecated auth sources #35272
Open
+41
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entra ID users should use the OIDC oauth2 provider
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Aug 15, 2025
lunny
reviewed
Aug 15, 2025
| @@ -83,13 +89,43 @@ func RegisterGothProvider(provider GothProvider) { | |||
| gothProviders[provider.Name()] = provider | |||
| } | |||
|
|
|||
| // hasExistingAzureADAuthSources checks if there are any existing Azure AD auth sources configured | |||
| func hasExistingAzureADAuthSources(ctx context.Context) bool { | |||
There was a problem hiding this comment.
Maybe we should return the existed types as []string but not only the bool and then just list the exists providers but all the 3 types.
There was a problem hiding this comment.
I chose the structure I did because then we don’t need to loop over slice for each provider instead we can have o(1) of checking if the value from map is true.
There was a problem hiding this comment.
No. If you have over 1M items, maps is better than slices. But if you have only 3 items, you should not consider that. The current implementation will list all the 3 types even if only 1 type auth source does exist which is unncessary.
6543
approved these changes
Aug 17, 2025
GiteaBot
added
lgtm/need 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entra ID users should use the OIDC oauth2 provider.
They will still be shown if the instance has a previous Azure AD source configured.