Skip to content

Make GILRS and WINIT_WINDOWS public #19575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2025
Merged

Make GILRS and WINIT_WINDOWS public #19575

merged 4 commits into from
Jun 12, 2025

Conversation

joshua-holmes
Copy link
Contributor

@joshua-holmes joshua-holmes commented Jun 11, 2025 •
edited by alice-i-cecile
Loading

After removing !Send resources, GILRS and WINIT_WINDOWS were not made public, which is a breaking change. This was brought up in a comment on that PR. This PR makes them public.

Fixes #19540.

@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Jun 11, 2025
IceSentry
IceSentry approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small note, but other than that LGTM

Thank you

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events A-Windowing Platform-agnostic interface layer to run your app in C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it P-Regression Functionality that used to work but no longer does. Add a test for this! labels Jun 11, 2025
@alice-i-cecile
Copy link
Member

Waiting a bit for the response on the comment above, but I won't block on it :)

@joshua-holmes
Copy link
Contributor Author

Thanks for the suggestion @IceSentry! I added to the document

@alice-i-cecile
Copy link
Member

Great stuff :) Let me know when you've got the Markdown nag bot happy and I'll merge this!

@joshua-holmes
Copy link
Contributor Author

Looks like the linting job is passing @alice-i-cecile

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 12, 2025
Merged via the queue into bevyengine:main with commit 8010185 Jun 12, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@tychedelia tychedelia tychedelia approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Windowing Platform-agnostic interface layer to run your app in C-Usability A targeted quality-of-life change that makes Bevy easier to use P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.

Missing migration guide for WINIT_WINDOWS
4 participants
@joshua-holmes @alice-i-cecile @IceSentry @tychedelia