Remove remaining internal use of !Send resources
#18386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-ECS
|
I'm going to want @maniwani's eyes on this, hence the X-Controversial label. |
hymm
reviewed
Mar 18, 2025
hymm
reviewed
Mar 18, 2025
joshua-holmes
changed the title
!Send!Send resources
|
The work on this PR is complete, but we are waiting for |
chescock
approved these changes
Mar 20, 2025
joshua-holmes
force-pushed
the
no-more-non-send
branch
3 times, most recently
from
8b6d428 to
ec82c5f
Compare
maniwani
approved these changes
Mar 23, 2025
|
Merging the linked PR for you :) |
joshua-holmes
force-pushed
the
no-more-non-send
branch
from
ad60838 to
ec82c5f
Compare
Co-authored-by: Chris Russell <8494645+chescock@users.noreply.github.com>
…DAPTERS` Co-authored-by: Chris Russell <8494645+chescock@users.noreply.github.com>
joshua-holmes
force-pushed
the
no-more-non-send
branch
from
ec82c5f to
7bce0d2
Compare
joshua-holmes
force-pushed
the
no-more-non-send
branch
2 times, most recently
from
25caa7c to
158f3f6
Compare
joshua-holmes
force-pushed
the
no-more-non-send
branch
from
158f3f6 to
8907bf1
Compare
alice-i-cecile
added
X-Blessed
|
Thank you so much for tackling this! I'm really happy that this is finally done, now we just need to remove the old |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alice-i-cecile
added
S-Waiting-on-Author
|
Back to Waiting-on-Author until CI issues are resolved :( |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
andrewzhurov
pushed a commit
to andrewzhurov/bevy
that referenced
this pull request
May 17, 2025
# Objective Remaining work for and closes bevyengine#17682. First half of work for that issue was completed in [PR 17730](bevyengine#17730). However, the rest of the work ended up getting blocked because we needed a way of forcing systems to run on the main thread without the use of `!Send` resources. That was unblocked by [PR 18301](bevyengine#18301). This work should finish unblocking the resources-as-components effort. # Testing Ran several examples using my Linux machine, just to make sure things are working as expected and no surprises pop up. --------- Co-authored-by: Chris Russell <8494645+chescock@users.noreply.github.com> Co-authored-by: François Mockers <francois.mockers@vleue.com>
|
Where's the migration guide for this PR? Also, why is WINIT_WINDOWS private? That's a huge breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Remaining work for and closes #17682. First half of work for that issue was completed in PR 17730. However, the rest of the work ended up getting blocked because we needed a way of forcing systems to run on the main thread without the use of
!Sendresources. That was unblocked by PR 18301.This work should finish unblocking the resources-as-components effort.
Testing
Ran several examples using my Linux machine, just to make sure things are working as expected and no surprises pop up.