-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Update rand
, glam
and encase
to latest versions
#18047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bluefinger
wants to merge
5
commits into
bevyengine:main
Choose a base branch
from
Bluefinger:rand-v0.9-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2025
1d955c8
to
02c1ca9
Compare
mrchantey
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lots of files changed but as mentioned in the pr its a 1:1 mapping to the updated function naming convention. I'm sure the wasm rustflags will be a gotcha for many a rust newbie, it'll be helful for us to explain this as much as possible in docs and guides.
This was referenced May 3, 2025
02c1ca9
to
6b8bb28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Math
Fundamental domain-agnostic mathematical operations
C-Dependencies
A change to the crates that Bevy depends on
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Blocked
This cannot move forward until something else changes
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
New
rand
version, which means updatingglam
andencase
to support the newer ecosystem update. Does mean that this changes how WASM builds need to be done in order to configuregetrandom
correctly, but this can be remedied with updated docs.Solution
Updating all needed dependencies to their compatible versions.
This PR is currently blocked byencase
, which is waiting on this PR to be merged and then a new version published.This PR is no longer blocked,hexasphere
is blocking this PR now due to not yet having a new release with the latestglam
version support.Testing
Migration Guide
With newer versions of
glam
&encase
, the updated versions don't seem to have introduced breakages, though as always, best to consult their docs 1 2 for any changes.rand
changes are more extensive, with changes such asthread_rng()
->rng()
,from_entropy()
->from_os_rng()
, and so forth.RngCore
is now split into infallibleRngCore
and fallibleTryRngCore
, and thedistributions
module has been renamed todistr
. Most of this affects only internals, and doesn't directly affect Bevy's APIs. For the full set of changes, seerand
migration notes.getrandom
is also updated, and will require additional configuration when building Bevy for WASM/Web (if also usingrand
). The full details of how to do this is in thegetrandom
docs 1 2.