Update to Glam 0.30.1 and adopt nostd-libm feature
#18474
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
added
D-Trivial
andriyDev
suggested changes
Mar 22, 2025
|
This has significant overlap with #18047 (I should've done more research before opening this PR!) I'll coordinate on that PR first and see if the possible blocker on encase can be resolved. If not, this may need to wait for 0.17 |
bushrat011899
added
S-Waiting-on-Author
|
probably not for the 0.16, as updating glam comes with other crates to update that are not ready |
|
Since there are two alternate approaches (either upgrade to 0.30 and then add this feature, or get Glam to release a 0.29.3 with the feature backported) I'm going to close this PR while we see which option presents itself! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
# Objective - Fixes #18397 - Supersedes #18474 - Simplifies 0.16 migration ## Solution - Upgrade to Glam 0.29.3, which has backported the `nostd-libm` feature. - Expose a similar feature in `bevy_math` and enable it in `bevy_internal`, allowing `bevy_math`, `bevy_input`, and `bevy_transform` to be unconditional dependencies again. ## Testing - CI --- ## Notes - This includes `libm` as a dependency, but this was already the case in the common scenario where `rand` or many other features were enabled. Considering `libm` is an official Rust crate, it's a very low-risk dependency to unconditionally include. - For users who do not want `libm` included, simply import Bevy's subcrates directly, since `bevy_math/nostd-libm` will not be enabled. - I know we are _very_ late in the RC cycle for 0.16, but this has a substantial impact on the usability of `bevy` that I consider worth including.
mockersf
pushed a commit
that referenced
this pull request
Mar 31, 2025
- Fixes #18397 - Supersedes #18474 - Simplifies 0.16 migration - Upgrade to Glam 0.29.3, which has backported the `nostd-libm` feature. - Expose a similar feature in `bevy_math` and enable it in `bevy_internal`, allowing `bevy_math`, `bevy_input`, and `bevy_transform` to be unconditional dependencies again. - CI --- - This includes `libm` as a dependency, but this was already the case in the common scenario where `rand` or many other features were enabled. Considering `libm` is an official Rust crate, it's a very low-risk dependency to unconditionally include. - For users who do not want `libm` included, simply import Bevy's subcrates directly, since `bevy_math/nostd-libm` will not be enabled. - I know we are _very_ late in the RC cycle for 0.16, but this has a substantial impact on the usability of `bevy` that I consider worth including.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_inputis now optional, but there's no way to enable it #18397bevySolution
nostd-libmfeaturebevy_mathbevy_math/nostd-libminbevy_internalbevy_math,bevy_transform, andbevy_inputinbevy_internal(reverting to pre-0.16 behaviour)Testing
Notes
This causes
bevyto always includelibmas a dependency, but it is a very small and high quality one from the Rust language team themselves. Crucially, thelibmandstdfeatures can both override the use ofnostd-libm, still giving users total control over which implementation they wish to use in both Glam andbevy_math. I believe the singular forced dependency is worth it for the increased functionality thatdefault-features = falseBevy can provide.For users who cannot accept that dependency, you can depend directly on Bevy's sub-crates instead, which is generally recommended for enthusiast users anyway.