bevy_render: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)]
#17194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout_reason)]` to bevy_render
LikeLakers2
commented
Jan 6, 2025
| #![expect( | ||
| clippy::module_inception, | ||
| reason = "The parent module contains all things viewport-related, while this module handles cameras as a component." | ||
| )] |
There was a problem hiding this comment.
The issue of the module sharing a name with its parent is out-of-scope for this PR; but I have created an issue on the matter: #17196
There was a problem hiding this comment.
The issue number should go in the reason comment
There was a problem hiding this comment.
Good point, let me do that.
LikeLakers2
commented
Jan 6, 2025
Comment on lines
+241
to
+244
| #[expect( | ||
| clippy::match_same_arms, | ||
| reason = "LoadedWithDependencies is marked as a TODO, so it's likely this will no longer lint soon." | ||
| )] |
There was a problem hiding this comment.
I am not a fan of this reason... but I also didn't know what else to do, because merging the two arms would mean removing the // TODO comment.
Comment on lines
+919
to
+922
| #[expect( | ||
| clippy::match_same_arms, | ||
| reason = "LoadedWithDependencies is marked as a TODO, so it's likely this will no longer lint soon." | ||
| )] |
2 tasks
BenjaminBrienen
approved these changes
Jan 6, 2025
BenjaminBrienen
added
D-Trivial
…where the weird naming is being discussed
BenjaminBrienen
approved these changes
Jan 6, 2025
BenjaminBrienen
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Jan 6, 2025
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
…ttributes_without_reason)]` (bevyengine#17194) # Objective - bevyengine#17111 ## Solution Set the `clippy::allow_attributes` and `clippy::allow_attributes_without_reason` lints to `deny`, and bring `bevy_render` in line with the new restrictions. ## Testing `cargo clippy` and `cargo test --package bevy_render` were run, and no errors were encountered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
clippy::allow_attributesandclippy::allow_attributes_without_reasonlints #17111Solution
Set the
clippy::allow_attributesandclippy::allow_attributes_without_reasonlints todeny, and bringbevy_renderin line with the new restrictions.Testing
cargo clippyandcargo test --package bevy_renderwere run, and no errors were encountered.