Skip to content

Document why MAX_JOINTS and MAX_MORPH_WEIGHTS are set #16324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

Document why MAX_JOINTS and MAX_MORPH_WEIGHTS are set #16324

merged 1 commit into from
Dec 10, 2024

Conversation

BenjaminBrienen
Copy link
Contributor

Objective

Fixes #15974

Solution

Add the comment from @mockersf, adapted to fix in-context.

@BenjaminBrienen BenjaminBrienen self-assigned this Nov 10, 2024
@BenjaminBrienen BenjaminBrienen added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 10, 2024
@JMS55 JMS55 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 9, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 10, 2024
Merged via the queue into bevyengine:main with commit b744fb4 Dec 10, 2024
35 checks passed
@BenjaminBrienen BenjaminBrienen deleted the Document-why-MAX_JOINTS-and-MAX_MORPH_WEIGHTS-are-set branch December 10, 2024 05:45
@BenjaminBrienen BenjaminBrienen removed the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 10, 2024
BD103 pushed a commit to BD103/bevy that referenced this pull request Dec 10, 2024
@BenjaminBrienen @BD103
Document why MAX_JOINTS and MAX_MORPH_WEIGHTS are set (bevyengine…
2020269 
…#16324)

# Objective

Fixes bevyengine#15974

## Solution

Add the comment from @mockersf, adapted to fix in-context.
@victorb victorb mentioned this pull request Jan 3, 2025
Open
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@BenjaminBrienen @ecoskey
Document why MAX_JOINTS and MAX_MORPH_WEIGHTS are set (bevyengine…
ecef013 
…#16324)

# Objective

Fixes bevyengine#15974

## Solution

Add the comment from @mockersf, adapted to fix in-context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document why MAX_JOINTS and MAX_MORPH_WEIGHTS are set
4 participants
@BenjaminBrienen @alice-i-cecile @mockersf @JMS55