[Merged by Bors] - better error message on failed derive #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Feb 21, 2021
There was a problem hiding this comment.
Since we use Box as a raw identifier here, it should be fine, but it's worth considering whether we want to require that crates which use our macros should always require the prelude be included.
In this case however, this change is a clear win and these thoughts are unrelated to the changes here.
DJMcNab
added
the
S-Ready-For-Final-Review
Ratysz
added
C-Code-Quality
Ratysz
approved these changes
Feb 21, 2021
mockersf
approved these changes
Feb 21, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2021
Before, when deriving `SystemLabel` for a type without `Clone`, the error message was: ``` the trait `SystemLabel` is not implemented for `&TransformSystem` ``` Now it is ``` the trait `Clone` is not implemented for `TransformSystem` ``` which directly shows what's needed to fix the problem.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when deriving
SystemLabelfor a type withoutClone, the error message was:Now it is
which directly shows what's needed to fix the problem.