Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix incorrect docs in the run conditions example #14377

Merged
merged 1 commit into from
Jul 20, 2024
Merged

docs: Fix incorrect docs in the run conditions example #14377

merged 1 commit into from
Jul 20, 2024

Conversation

LiamGallagher737
Copy link
Member

Objective

Make the docs say the right thing.

Solution

Edit the docs so they say the right thing.

Seems like overtime the example has changed but the comment did not change with it. It originally was a AND but is now an OR.

@IQuick143 IQuick143 added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 18, 2024
BD103
BD103 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@BD103 BD103 added A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 18, 2024
@mockersf mockersf added this pull request to the merge queue Jul 20, 2024
Merged via the queue into bevyengine:main with commit 11ecc4d Jul 20, 2024
34 checks passed
@LiamGallagher737 LiamGallagher737 deleted the fix-run-conditions-example-docs branch July 20, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@IQuick143 IQuick143 IQuick143 approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiamGallagher737 @mockersf @IQuick143 @BD103