Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual --cfg docsrs #14376

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Remove manual --cfg docsrs #14376

merged 5 commits into from
Jul 22, 2024

Conversation

Coder-Joe458
Copy link
Contributor

@Coder-Joe458 Coder-Joe458 commented Jul 18, 2024 •
edited
Loading

Objective

Solution

  • Remove the cfg docsrs

@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@BD103 BD103 added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-Cross-Cutting Impacts the entire engine S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jul 18, 2024
@Coder-Joe458 Coder-Joe458 marked this pull request as ready for review July 19, 2024 17:40
@BD103 BD103 added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jul 19, 2024
BD103
BD103 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 22, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 22, 2024
Merged via the queue into bevyengine:main with commit 8f53455 Jul 22, 2024
32 checks passed
@Coder-Joe458 Coder-Joe458 deleted the rmdocsrs branch July 23, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-Cross-Cutting Impacts the entire engine C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove manual --cfg docsrs in Cargo.toml metadata
3 participants
@Coder-Joe458 @alice-i-cecile @BD103