Fix CameraProjectionPlugin not implementing Plugin in some cases#11766
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Feb 26, 2024
Merged
Conversation
alice-i-cecile
added
C-Bug
pablo-lua
approved these changes
Feb 11, 2024
Contributor
pablo-lua
left a comment
pablo-lua
left a comment
There was a problem hiding this comment.
If the Plugin has thoses bounds, and I cannot use a CameraProjectionPlugin as a Plugin unless thoses bounds are fulfilled, then we must require thoses bounds in the struct as well.
nicopap
approved these changes
Feb 21, 2024
nicopap
added
the
S-Ready-For-Final-Review
hymm
added
the
M-Migration-Guide
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…evyengine#11766) # Objective `CameraProjectionPlugin<T>`'s bounds are `T: CameraProjection`. But the bounds for `CameraProjectionPlugin` implementing `Plugin` are `T: CameraProjection + Component + GetTypeRegistration`. This means that if `T` is valid for `CameraProjectionPlugin`'s bounds, but not the plugin implementation's bounds, then `CameraProjectionPlugin` would not implement `Plugin`. Which is weird because you'd expect a struct with `Plugin` in the name to implement `Plugin`. ## Solution Make `CameraProjectionPlugin<T>`'s bounds `T: CameraProjection + Component + GetTypeRegistration`. I also rearranged some of the code. --- ## Changelog - Changed `CameraProjectionPlugin<T>`'s bounds to `T: CameraProjection + Component + GetTypeRegistration` ## Migration Guide `CameraProjectionPlugin<T>`'s trait bounds now require `T` to implement `CameraProjection`, `Component`, and `GetTypeRegistration`. This shouldn't affect most existing code as `CameraProjectionPlugin<T>` never implemented `Plugin` unless those bounds were met.
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…evyengine#11766) # Objective `CameraProjectionPlugin<T>`'s bounds are `T: CameraProjection`. But the bounds for `CameraProjectionPlugin` implementing `Plugin` are `T: CameraProjection + Component + GetTypeRegistration`. This means that if `T` is valid for `CameraProjectionPlugin`'s bounds, but not the plugin implementation's bounds, then `CameraProjectionPlugin` would not implement `Plugin`. Which is weird because you'd expect a struct with `Plugin` in the name to implement `Plugin`. ## Solution Make `CameraProjectionPlugin<T>`'s bounds `T: CameraProjection + Component + GetTypeRegistration`. I also rearranged some of the code. --- ## Changelog - Changed `CameraProjectionPlugin<T>`'s bounds to `T: CameraProjection + Component + GetTypeRegistration` ## Migration Guide `CameraProjectionPlugin<T>`'s trait bounds now require `T` to implement `CameraProjection`, `Component`, and `GetTypeRegistration`. This shouldn't affect most existing code as `CameraProjectionPlugin<T>` never implemented `Plugin` unless those bounds were met.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 27, 2024
…1808) # Objective Fix #11799 and improve `CameraProjectionPlugin` ## Solution `CameraProjectionPlugin` is now an all-in-one plugin for adding a custom `CameraProjection`. I also added `PbrProjectionPlugin` which is like `CameraProjectionPlugin` but for PBR. P.S. I'd like to get this merged after #11766. --- ## Changelog - Changed `CameraProjectionPlugin` to be an all-in-one plugin for adding a `CameraProjection` - Removed `VisibilitySystems::{UpdateOrthographicFrusta, UpdatePerspectiveFrusta, UpdateProjectionFrusta}`, now replaced with `VisibilitySystems::UpdateFrusta` - Added `PbrProjectionPlugin` for projection-specific PBR functionality. ## Migration Guide `VisibilitySystems`'s `UpdateOrthographicFrusta`, `UpdatePerspectiveFrusta`, and `UpdateProjectionFrusta` variants were removed, they were replaced with `VisibilitySystems::UpdateFrusta`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
CameraProjectionPlugin<T>'s bounds areT: CameraProjection. But the bounds forCameraProjectionPluginimplementingPluginareT: CameraProjection + Component + GetTypeRegistration. This means that ifTis valid forCameraProjectionPlugin's bounds, but not the plugin implementation's bounds, thenCameraProjectionPluginwould not implementPlugin. Which is weird because you'd expect a struct withPluginin the name to implementPlugin.Solution
Make
CameraProjectionPlugin<T>'s boundsT: CameraProjection + Component + GetTypeRegistration. I also rearranged some of the code.Changelog
CameraProjectionPlugin<T>'s bounds toT: CameraProjection + Component + GetTypeRegistrationMigration Guide
CameraProjectionPlugin<T>'s trait bounds now requireTto implementCameraProjection,Component, andGetTypeRegistration. This shouldn't affect most existing code asCameraProjectionPlugin<T>never implementedPluginunless those bounds were met.